corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1959949 - Don't reparse empty style attributes. r=emilio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D245400
This commit is contained in:
Tom Schuster
2025-04-14 11:56:56 +00:00
parent 363f64a736
commit 2df53d3d7e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/base/nsStyledElement.cpp
View File

@@ -138,7 +138,10 @@ nsresult nsStyledElement::ReparseStyleAttribute(bool aForceInDataDoc) {
nsAttrValue attrValue; nsAttrValue attrValue;
nsAutoString stringValue; nsAutoString stringValue;
oldVal->ToString(stringValue); oldVal->ToString(stringValue);
ParseStyleAttribute(stringValue, nullptr, attrValue, aForceInDataDoc); if (!stringValue.IsEmpty()) {
// Prevent CSP errors from re-parsing a style that was already blocked.
ParseStyleAttribute(stringValue, nullptr, attrValue, aForceInDataDoc);
}
// Don't bother going through SetInlineStyleDeclaration; we don't // Don't bother going through SetInlineStyleDeclaration; we don't
// want to fire off mutation events or document notifications anyway // want to fire off mutation events or document notifications anyway
bool oldValueSet; bool oldValueSet;
@@ -168,8 +171,9 @@ void nsStyledElement::ParseStyleAttribute(const nsAString& aValue,
if (!isNativeAnon && if (!isNativeAnon &&
!nsStyleUtil::CSPAllowsInlineStyle(this, doc, aMaybeScriptedPrincipal, 0, !nsStyleUtil::CSPAllowsInlineStyle(this, doc, aMaybeScriptedPrincipal, 0,
1, aValue, nullptr)) 1, aValue, nullptr)) {
return; return;
}
if (aForceInDataDoc || !doc->IsLoadedAsData() || GetExistingStyle() || if (aForceInDataDoc || !doc->IsLoadedAsData() || GetExistingStyle() ||
doc->IsStaticDocument()) { doc->IsStaticDocument()) {