corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1890427 - Part 6: Use an observer to regenerate backups when an address is deleted. r=backup-reviewers,kpatenio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D218876
This commit is contained in:
Mike Conley
2024-09-04 17:56:57 +00:00
parent 01d75928e9
commit 2d3cbfc487
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
browser/components/backup/BackupService.sys.mjs
View File

@@ -3231,7 +3231,8 @@ export class BackupService extends EventTarget {
case "formautofill-storage-changed": { case "formautofill-storage-changed": {
if ( if (
data == "remove" && data == "remove" &&
subject.wrappedJSObject.collectionName == "creditCards" (subject.wrappedJSObject.collectionName == "creditCards" ||
subject.wrappedJSObject.collectionName == "addresses")
) { ) {
this.#debounceRegeneration(); this.#debounceRegeneration();
} }

24
browser/components/backup/tests/xpcshell/test_BackupService_regeneration.js
View File

@@ -415,3 +415,27 @@ add_task(async function test_payment_method_removed() {
await formAutofillStorage.creditCards.remove(guid); await formAutofillStorage.creditCards.remove(guid);
}, "Saw regeneration on payment method removal."); }, "Saw regeneration on payment method removal.");
}); });
/**
* Tests that backup regeneration occurs when removing an address.
*/
add_task(async function test_address_removed() {
await formAutofillStorage.initialize();
let guid = await formAutofillStorage.addresses.add({
"given-name": "John",
"additional-name": "R.",
"family-name": "Smith",
organization: "World Wide Web Consortium",
"street-address": "32 Vassar Street\\\nMIT Room 32-G524",
"address-level2": "Cambridge",
"address-level1": "MA",
"postal-code": "02139",
country: "US",
tel: "+15195555555",
email: "user@example.com",
});
await expectRegeneration(async () => {
await formAutofillStorage.addresses.remove(guid);
}, "Saw regeneration on address removal.");
});