Bug 1896516 Part 5 - Fix build errors after including ScrollContainerFrame.h under dom/animation/. r=layout-reviewers,boris

This is a preparation to remove `#include "nsIScrollableFrame.h"` for
ScrollTimeline.cpp and ViewTimeline.cpp.

Move the implementation of `nsListControlFrame::GetMultiple()` to cpp. Keeping
it inline requires adding `#include "mozilla/dom/Element.h"` in the header, and
I don't feel the method is hot enough to be inlined.

Differential Revision: https://phabricator.services.mozilla.com/D211492

dom/animation/ScrollTimeline.cpp

@@ -12,6 +12,7 @@
 #include "mozilla/DisplayPortUtils.h"
 #include "mozilla/ElementAnimationData.h"
 #include "mozilla/PresShell.h"
+#include "mozilla/ScrollContainerFrame.h"
 #include "nsIFrame.h"
 #include "nsIScrollableFrame.h"
 #include "nsLayoutUtils.h"

dom/animation/ViewTimeline.cpp

@@ -8,6 +8,7 @@
 
 #include "mozilla/dom/Animation.h"
 #include "mozilla/dom/ElementInlines.h"
+#include "mozilla/ScrollContainerFrame.h"
 #include "nsIScrollableFrame.h"
 #include "nsLayoutUtils.h"
 

layout/forms/nsListControlFrame.cpp

@@ -668,6 +668,10 @@ void nsListControlFrame::SetInitialChildList(ChildListID aListID,
   ScrollContainerFrame::SetInitialChildList(aListID, std::move(aChildList));
 }
 
+bool nsListControlFrame::GetMultiple() const {
+  return mContent->AsElement()->HasAttr(nsGkAtoms::multiple);
+}
+
 HTMLSelectElement& nsListControlFrame::Select() const {
   return *static_cast<HTMLSelectElement*>(GetContent());
 }

layout/forms/nsListControlFrame.h

@@ -225,9 +225,7 @@ class nsListControlFrame final : public mozilla::ScrollContainerFrame,
   /**
    * Returns whether mContent supports multiple selection.
    */
-  bool GetMultiple() const {
+  bool GetMultiple() const;
-    return mContent->AsElement()->HasAttr(nsGkAtoms::multiple);
-  }
 
   mozilla::dom::HTMLSelectElement& Select() const;
 

layout/generic/ScrollContainerFrame.cpp

@@ -96,6 +96,7 @@
 #include "mozilla/layers/ScrollLinkedEffectDetector.h"
 #include "mozilla/Unused.h"
 #include "MobileViewportManager.h"
+#include "TextOverflow.h"
 #include "VisualViewport.h"
 #include "WindowRenderer.h"
 #include <algorithm>

layout/generic/ScrollContainerFrame.h

@@ -19,7 +19,6 @@
 #include "nsIReflowCallback.h"
 #include "nsQueryFrame.h"
 #include "nsExpirationTracker.h"
-#include "TextOverflow.h"
 #include "ScrollVelocityQueue.h"
 #include "mozilla/ScrollTypes.h"
 #include "mozilla/PresState.h"
@@ -33,6 +32,7 @@ class nsIScrollPositionListener;
 class AutoContainsBlendModeCapturer;
 
 namespace mozilla {
+struct nsDisplayListCollection;
 class PresShell;
 enum class StyleScrollbarWidth : uint8_t;
 class ScrollContainerFrame;

layout/generic/moz.build

@@ -129,6 +129,7 @@ EXPORTS += [
     "ScrollAnimationPhysics.h",
     "ScrollbarActivity.h",
     "ScrollSnap.h",
+    "ScrollVelocityQueue.h",
     "TextDrawTarget.h",
     "Visibility.h",
 ]