Bug 1132934 part 1. Actually propagate out exceptions from the innerHTML getter. r=smaug

MozReview-Commit-ID: KEqsx836qQn
2018-03-26 16:41:43 -04:00
parent baa5890074
commit 29302e62f2
8 changed files with 14 additions and 16 deletions
--- a/dom/html/HTMLScriptElement.cpp
+++ b/dom/html/HTMLScriptElement.cpp
@@ -136,13 +136,12 @@ HTMLScriptElement::AfterSetAttr(int32_t aNamespaceID, nsAtom* aName,
                                            aNotify);
 }

-NS_IMETHODIMP
-HTMLScriptElement::GetInnerHTML(nsAString& aInnerHTML)
+void
+HTMLScriptElement::GetInnerHTML(nsAString& aInnerHTML, ErrorResult& aRv)
 {
  if (!nsContentUtils::GetNodeTextContent(this, false, aInnerHTML, fallible)) {
-    return NS_ERROR_OUT_OF_MEMORY;
+    aRv.Throw(NS_ERROR_OUT_OF_MEMORY);
  }
-  return NS_OK;
 }

 void