Bug 900979 - Change JS_DeleteProperty APIs to use a boolean out param rather than a value r=waldo r=bz

2013-08-05 14:01:53 +01:00
parent 1d768f5a5c
commit 28abf58d87
9 changed files with 29 additions and 60 deletions
--- a/js/ipc/JavaScriptChild.cpp
+++ b/js/ipc/JavaScriptChild.cpp
@@ -284,15 +284,9 @@ JavaScriptChild::AnswerDelete(const ObjectId &objId, const nsString &id, ReturnS
    if (!convertGeckoStringToId(cx, id, &internedId))
        return fail(cx, rs);

-    RootedValue v(cx);
-    if (!JS_DeletePropertyById2(cx, obj, internedId, &v))
+    if (!JS_DeletePropertyById2(cx, obj, internedId, success))
        return fail(cx, rs);

-    JSBool b;
-    if (!JS_ValueToBoolean(cx, v, &b))
-        return fail(cx, rs);
-    *success = !!b;
-
    return ok(rs);
 }