Bug 1439155: Be consistent about what does readonly apply to. r=smaug

MozReview-Commit-ID: 4NiDe7pUzGa
This commit is contained in:
Emilio Cobos Álvarez
2018-02-22 08:07:55 +01:00
parent 910c0b0367
commit 24dd511927
6 changed files with 112 additions and 49 deletions

View File

@@ -6909,46 +6909,6 @@ HTMLInputElement::IsMutable() const
HasAttr(kNameSpaceID_None, nsGkAtoms::readonly));
}
bool
HTMLInputElement::DoesReadOnlyApply() const
{
switch (mType)
{
case NS_FORM_INPUT_HIDDEN:
case NS_FORM_INPUT_BUTTON:
case NS_FORM_INPUT_IMAGE:
case NS_FORM_INPUT_RESET:
case NS_FORM_INPUT_SUBMIT:
case NS_FORM_INPUT_RADIO:
case NS_FORM_INPUT_FILE:
case NS_FORM_INPUT_CHECKBOX:
case NS_FORM_INPUT_RANGE:
case NS_FORM_INPUT_COLOR:
return false;
#ifdef DEBUG
case NS_FORM_INPUT_TEXT:
case NS_FORM_INPUT_PASSWORD:
case NS_FORM_INPUT_SEARCH:
case NS_FORM_INPUT_TEL:
case NS_FORM_INPUT_EMAIL:
case NS_FORM_INPUT_URL:
case NS_FORM_INPUT_NUMBER:
case NS_FORM_INPUT_DATE:
case NS_FORM_INPUT_TIME:
case NS_FORM_INPUT_MONTH:
case NS_FORM_INPUT_WEEK:
case NS_FORM_INPUT_DATETIME_LOCAL:
return true;
default:
MOZ_ASSERT_UNREACHABLE("Unexpected input type in DoesReadOnlyApply()");
return true;
#else // DEBUG
default:
return true;
#endif // DEBUG
}
}
bool
HTMLInputElement::DoesRequiredApply() const
{