corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Backed out changeset 93cf5f317f98 (bug 1676785) for causing mochitest failures in test_input_value_set_preserve_undo.xhtml

Browse Source 
CLOSED TREE
This commit is contained in:
Mihai Alexandru Michis
2020-12-02 14:05:18 +02:00
parent 150eb854dc
commit 239e23dc4e
10 changed files with 108 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dom/html/HTMLInputElement.cpp
View File

@@ -2641,14 +2641,10 @@ nsresult HTMLInputElement::SetValueInternal(const nsAString& aValue,
// We want to remember if the SetValueInternal() call is being made for a XUL
// element. We do that by looking at the parent node here, and if that node
// is a XUL node, we consider our control a XUL control. XUL controls preserve
// edit history across value setters.
//
// TODO(emilio): Rather than doing this maybe add an attribute instead and
// read it only on chrome docs or something? That'd allow front-end code to
// move away from xul without weird side-effects.
if (mParent && mParent->IsXULElement()) {
aFlags |= TextControlState::eSetValue_PreserveHistory;
// is a XUL node, we consider our control a XUL control.
nsIContent* parent = GetParent();
if (parent && parent->IsXULElement()) {
aFlags |= TextControlState::eSetValue_ForXUL;
}
switch (GetValueMode()) {