corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Backed out 3 changesets (bug 1653123, bug 1602115) for perma failures on test_history_length_during_pageload.html. CLOSED TREE

Browse Source 
Backed out changeset 6b3c0f542ef3 (bug 1653123)
Backed out changeset 951c0fd65a00 (bug 1602115)
Backed out changeset 258d0ebd9e34 (bug 1602115)
This commit is contained in:
Razvan Maries
2020-07-16 23:21:18 +03:00
parent 5b2d248279
commit 22f0615ea7
20 changed files with 30 additions and 340 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
docshell/base/CanonicalBrowsingContext.cpp
View File

@@ -282,7 +282,7 @@ CanonicalBrowsingContext::CreateSessionHistoryEntryForLoad(
}
void CanonicalBrowsingContext::SessionHistoryCommit(
uint64_t aSessionHistoryEntryId, const nsID& aChangeID) {
uint64_t aSessionHistoryEntryId) {
for (size_t i = 0; i < mLoadingEntries.Length(); ++i) {
if (mLoadingEntries[i]->Info().Id() == aSessionHistoryEntryId) {
nsISHistory* shistory = GetSessionHistory();
@@ -319,13 +319,9 @@ void CanonicalBrowsingContext::SessionHistoryCommit(
}
}
Group()->EachParent([&](ContentParent* aParent) {
nsISHistory* shistory = GetSessionHistory();
int32_t index = 0;
int32_t length = 0;
shistory->GetIndex(&index);
shistory->GetCount(&length);
Unused << aParent->SendHistoryCommitIndexAndLength(Top(), index, length,
aChangeID);
// FIXME Should we return the length to the one process that committed
// as an async return value? Or should this use synced fields?
Unused << aParent->SendHistoryCommitLength(Top(), shistory->GetCount());
});
return;
}