Bug 1920733 - Adjust fuzzy annotations etc for testcases affected by disabling the forced-gdi-classic rendering pref. r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D225074
This commit is contained in:
@@ -56,7 +56,7 @@ fuzzy-if(gtkWidget,0-1,0-8) fuzzy-if(Android,0-4,0-2) == select-1.html select-1-
|
|||||||
fuzzy-if(gtkWidget,0-1,0-8) fuzzy-if(Android,0-4,0-2) == select-1-dynamic.html select-1-ref.html
|
fuzzy-if(gtkWidget,0-1,0-8) fuzzy-if(Android,0-4,0-2) == select-1-dynamic.html select-1-ref.html
|
||||||
== select-2.html select-2-ref.html
|
== select-2.html select-2-ref.html
|
||||||
== select-3.html select-3-ref.html
|
== select-3.html select-3-ref.html
|
||||||
fuzzy-if(gtkWidget||winWidget,0-1,0-4) fuzzy-if(cocoaWidget,0-1,0-8) == select-4.html select-4-ref.html
|
fuzzy(0-1,0-8) == select-4.html select-4-ref.html
|
||||||
== multi-column-1.html multi-column-1-ref.html
|
== multi-column-1.html multi-column-1-ref.html
|
||||||
== button-1.html button-1-ref.html
|
== button-1.html button-1-ref.html
|
||||||
== button-2.html button-2-ref.html
|
== button-2.html button-2-ref.html
|
||||||
|
|||||||
@@ -178,6 +178,6 @@ fuzzy-if(cocoaWidget,0-1,0-3) fuzzy-if(Android,0-1,0-6) == brackets-3a-rtl.html
|
|||||||
== 1366623-1.html 1366623-1-ref.html
|
== 1366623-1.html 1366623-1-ref.html
|
||||||
== 1426042-1.html 1426042-1-ref.html # Bug 1392106
|
== 1426042-1.html 1426042-1-ref.html # Bug 1392106
|
||||||
== clone-intrinsic-size-bidi.html clone-intrinsic-size-bidi-ref.html
|
== clone-intrinsic-size-bidi.html clone-intrinsic-size-bidi-ref.html
|
||||||
fuzzy-if(winWidget,70-112,8-8) == slice-intrinsic-size-bidi.html slice-intrinsic-size-bidi-ref.html
|
fuzzy-if(winWidget,0-112,0-8) == slice-intrinsic-size-bidi.html slice-intrinsic-size-bidi-ref.html
|
||||||
== 1556414-1.html 1556414-1-ref.html
|
== 1556414-1.html 1556414-1-ref.html
|
||||||
== 1567036-1.html 1567036-1-ref.html
|
== 1567036-1.html 1567036-1-ref.html
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
== bounds-1.html bounds-1-ref.html
|
== bounds-1.html bounds-1-ref.html
|
||||||
fuzzy(0-65,0-3) == size-1.html size-1-ref.html
|
fuzzy(0-65,0-3) == size-1.html size-1-ref.html
|
||||||
fuzzy-if(winWidget,0-36,0-1) == size-2.html size-2-ref.html
|
fuzzy-if(winWidget,0-47,0-1) == size-2.html size-2-ref.html
|
||||||
== baseline-1.html baseline-1-ref.html
|
== baseline-1.html baseline-1-ref.html
|
||||||
== chrome://reftest/content/forms/input/text/centering-1.xhtml chrome://reftest/content/forms/input/text/centering-1-ref.xhtml
|
== chrome://reftest/content/forms/input/text/centering-1.xhtml chrome://reftest/content/forms/input/text/centering-1-ref.xhtml
|
||||||
== chrome://reftest/content/forms/input/text/dynamic-height-1.xhtml chrome://reftest/content/forms/input/text/dynamic-height-1-ref.xhtml
|
== chrome://reftest/content/forms/input/text/dynamic-height-1.xhtml chrome://reftest/content/forms/input/text/dynamic-height-1-ref.xhtml
|
||||||
|
|||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[text-emphasis-style-007.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-92;totalPixels=0-24
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[text-emphasis-style-012.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-76;totalPixels=0-12
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[text-emphasis-style-021.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-89;totalPixels=0-19
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-001.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-190;totalPixels=0-28
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-002.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-2313
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-003.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-257
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-004.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-507
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-005.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-1394
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-006.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-1231
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-007.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-170
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-008.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-1056
|
||||||
@@ -0,0 +1,3 @@
|
|||||||
|
[transform-input-010.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-508
|
||||||
@@ -1,4 +1,6 @@
|
|||||||
[transform-input-012.html]
|
[transform-input-012.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-833
|
||||||
expected:
|
expected:
|
||||||
if (os == "mac") and not debug: [FAIL, PASS]
|
if (os == "mac") and not debug: [FAIL, PASS]
|
||||||
if (os == "mac") and debug: FAIL
|
if (os == "mac") and debug: FAIL
|
||||||
|
|||||||
@@ -1,3 +1,5 @@
|
|||||||
[transform-input-014.html]
|
[transform-input-014.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-137;totalPixels=0-586
|
||||||
expected:
|
expected:
|
||||||
if os == "mac": [PASS, FAIL]
|
if os == "mac": [PASS, FAIL]
|
||||||
|
|||||||
@@ -1,4 +1,6 @@
|
|||||||
[transform-input-019.html]
|
[transform-input-019.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-127;totalPixels=0-378
|
||||||
expected:
|
expected:
|
||||||
if os == "mac": FAIL
|
if os == "mac": FAIL
|
||||||
if (os == "android"): FAIL
|
if (os == "android"): FAIL
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
[text-overflow-028.html]
|
[text-overflow-028.html]
|
||||||
expected:
|
expected:
|
||||||
if (os == "win"): FAIL
|
if (os == "win"): [PASS, FAIL]
|
||||||
if (os == "mac"): FAIL
|
if (os == "mac"): FAIL
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
[first-line-bidi-001.html]
|
[first-line-bidi-001.html]
|
||||||
fuzzy:
|
fuzzy:
|
||||||
if (os == "linux"): maxDifference=63;totalPixels=0-26
|
if (os == "linux"): maxDifference=63;totalPixels=0-26
|
||||||
if (os == "win"): maxDifference=63;totalPixels=0-44
|
if (os == "win"): maxDifference=63-92;totalPixels=0-44
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
[first-line-bidi-002.html]
|
[first-line-bidi-002.html]
|
||||||
fuzzy:
|
fuzzy:
|
||||||
if (os == "mac"): maxDifference=99-120;totalPixels=0-18
|
if (os == "mac"): maxDifference=99-120;totalPixels=0-18
|
||||||
if (os == "win"): maxDifference=13-29;totalPixels=0-18
|
if (os == "win"): maxDifference=13-143;totalPixels=0-19
|
||||||
|
|||||||
@@ -1,4 +0,0 @@
|
|||||||
[textarea-cols-rows.html]
|
|
||||||
[Cols/rows attribute values affect layout-dependent computed style]
|
|
||||||
expected:
|
|
||||||
if os == "mac": FAIL
|
|
||||||
@@ -1,3 +1,5 @@
|
|||||||
[dynamic-content-change-rendering.html]
|
[dynamic-content-change-rendering.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-190;totalPixels=0-28
|
||||||
expected:
|
expected:
|
||||||
if (os == "android"): FAIL
|
if (os == "android"): FAIL
|
||||||
|
|||||||
@@ -1,3 +1,5 @@
|
|||||||
[integration-point-3.html]
|
[integration-point-3.html]
|
||||||
|
fuzzy:
|
||||||
|
if os == "win": maxDifference=0-1;totalPixels=0-1
|
||||||
expected:
|
expected:
|
||||||
if (processor == "x86") and not debug: ["PASS", "FAIL"]
|
if (processor == "x86") and not debug: ["PASS", "FAIL"]
|
||||||
|
|||||||
@@ -18,7 +18,8 @@ function assert_width(number, text, shouldBeEqual) {
|
|||||||
let w2 = document.getElementById(text).getBoundingClientRect().width;
|
let w2 = document.getElementById(text).getBoundingClientRect().width;
|
||||||
|
|
||||||
if (shouldBeEqual) {
|
if (shouldBeEqual) {
|
||||||
assert_equals(w1, w2, `${number} vs. ${text}`);
|
const tolerance = 0.0001;
|
||||||
|
assert_less_than(Math.abs(w1 - w2), tolerance, `${number} vs. ${text}`);
|
||||||
} else {
|
} else {
|
||||||
assert_greater_than(w1, w2, `${number} vs. ${text}`);
|
assert_greater_than(w1, w2, `${number} vs. ${text}`);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -48,11 +48,11 @@ test(() => {
|
|||||||
test(() => {
|
test(() => {
|
||||||
const computedWidth = getComputedStyle(computed).width;
|
const computedWidth = getComputedStyle(computed).width;
|
||||||
assert_equals(computed.offsetWidth,
|
assert_equals(computed.offsetWidth,
|
||||||
parseInt(computedWidth.substring(0, computedWidth.length - 2)));
|
Math.round(computedWidth.substring(0, computedWidth.length - 2)));
|
||||||
|
|
||||||
const computedHeight = getComputedStyle(computed).height;
|
const computedHeight = getComputedStyle(computed).height;
|
||||||
assert_equals(computed.offsetHeight,
|
assert_equals(computed.offsetHeight,
|
||||||
parseInt(computedHeight.substring(0, computedHeight.length - 2)));
|
Math.round(computedHeight.substring(0, computedHeight.length - 2)));
|
||||||
}, 'Cols/rows attribute values affect layout-dependent computed style');
|
}, 'Cols/rows attribute values affect layout-dependent computed style');
|
||||||
|
|
||||||
test(() => {
|
test(() => {
|
||||||
|
|||||||
@@ -29,8 +29,8 @@ promise_test(async function() {
|
|||||||
// the iframe's viewport. Note that this is fragile and might need specific
|
// the iframe's viewport. Note that this is fragile and might need specific
|
||||||
// coordinates for each browser and maybe platform.
|
// coordinates for each browser and maybe platform.
|
||||||
const rect = inputElement.getBoundingClientRect();
|
const rect = inputElement.getBoundingClientRect();
|
||||||
const x = rect.x + rect.width - 10;
|
const x = Math.round(rect.x + rect.width - 10);
|
||||||
const y = rect.y + Math.round(rect.height / 4);
|
const y = Math.round(rect.y + rect.height / 4);
|
||||||
|
|
||||||
const actions = new test_driver.Actions()
|
const actions = new test_driver.Actions()
|
||||||
.pointerMove(x, y, { origin: "viewport" })
|
.pointerMove(x, y, { origin: "viewport" })
|
||||||
|
|||||||
@@ -114,7 +114,11 @@ add_task(async () => {
|
|||||||
// equal, but the DOMRect conversion is rounded to 1/65536 CSS pixels.
|
// equal, but the DOMRect conversion is rounded to 1/65536 CSS pixels.
|
||||||
// https://searchfox.org/mozilla-central/rev/380fc5571b039fd453b45bbb64ed13146fe9b066/dom/base/DOMRect.cpp#151-159
|
// https://searchfox.org/mozilla-central/rev/380fc5571b039fd453b45bbb64ed13146fe9b066/dom/base/DOMRect.cpp#151-159
|
||||||
// See also https://bugzilla.mozilla.org/show_bug.cgi?id=1640441#c28
|
// See also https://bugzilla.mozilla.org/show_bug.cgi?id=1640441#c28
|
||||||
const absTolerance = 1/65536
|
//
|
||||||
|
// Increased tolerance in https://bugzilla.mozilla.org/show_bug.cgi?id=1920733
|
||||||
|
// as the change to rendering mode seems to have perturbed results a bit, though
|
||||||
|
// it's still "basically the same".
|
||||||
|
const absTolerance = 0.05;
|
||||||
fuzzyCompareLength(menuRect2.width, menuRect1.width/2,
|
fuzzyCompareLength(menuRect2.width, menuRect1.width/2,
|
||||||
"width of menu font <p> in px", absTolerance, expectFn);
|
"width of menu font <p> in px", absTolerance, expectFn);
|
||||||
fuzzyCompareLength(menuRect2.height, menuRect1.height/2,
|
fuzzyCompareLength(menuRect2.height, menuRect1.height/2,
|
||||||
|
|||||||
Reference in New Issue
Block a user