corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1801936 - use moz-toggle in the ETP panel r=mstriemer,tgiles,desktop-theme-reviewers,flod,dao

Browse Source 
This patch replaces both toggles in the different sub views of the ETP panel with `moz-toggle`. Previously there was a small discrepancy where we were setting an `aria-label` on one toggle but not the other. I added a method to handle updating both toggles at once to ensure they stay in sync/always receive the same updates.

Differential Revision: https://phabricator.services.mozilla.com/D176700
This commit is contained in:
Hanna Jones
2023-08-09 18:18:44 +00:00
parent f13fdb7817
commit 20cbf2f575
7 changed files with 101 additions and 146 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
browser/components/controlcenter/content/protectionsPanel.inc.xhtml
View File

@@ -45,19 +45,8 @@
<vbox id="protections-popup-main-body" class="panel-subview-body">
<vbox id="protections-popup-tp-switch-section" class="protections-popup-section protections-popup-switch-section">
<hbox id="protections-popup-tp-switch-section-header" class="protections-popup-switch-section-header">
<vbox class="protections-popup-tp-switch-label-box" flex="1" align="start">
<label class="protections-popup-switch-header protections-popup-tp-switch-on-header"
role="heading"
aria-level="2" data-l10n-id="protections-panel-etp-on-header"></label>
<label class="protections-popup-switch-header protections-popup-tp-switch-off-header"
role="heading"
aria-level="2" data-l10n-id="protections-panel-etp-off-header"></label>
</vbox>
<vbox class="protections-popup-tp-switch-box">
<toolbarbutton id="protections-popup-tp-switch"
class="protections-popup-tp-switch"
enabled="false"
oncommand="gProtectionsHandler.onTPSwitchCommand();" />
<vbox class="protections-popup-tp-switch-box" flex="1" align="stretch">
<html:moz-toggle id="protections-popup-tp-switch" data-l10n-attrs="label, description"></html:moz-toggle>
</vbox>
</hbox>
<hbox id="protections-popup-tp-switch-section-footer">
@@ -193,19 +182,8 @@
role="document"
data-l10n-id="protections-panel-site-not-working-view">
<hbox id="protections-popup-siteNotWorkingView-header">
<vbox class="protections-popup-tp-switch-label-box" flex="1">
<label class="protections-popup-switch-header protections-popup-tp-switch-on-header"
role="heading"
aria-level="1" data-l10n-id="protections-panel-etp-on-header"></label>
<label class="protections-popup-switch-header protections-popup-tp-switch-off-header"
role="heading"
aria-level="1" data-l10n-id="protections-panel-etp-off-header"></label>
</vbox>
<vbox class="protections-popup-tp-switch-box">
<toolbarbutton id="protections-popup-siteNotWorking-tp-switch"
class="protections-popup-tp-switch"
enabled="false"
oncommand="gProtectionsHandler.onTPSwitchCommand();" />
<vbox class="protections-popup-tp-switch-box" flex="1" align="stretch">
<html:moz-toggle id="protections-popup-siteNotWorking-tp-switch" data-l10n-attrs="label, description"></html:moz-toggle>
</vbox>
</hbox>
<toolbarseparator></toolbarseparator>