Bug 1807899 - Remove the trailing whitespace and Windows CR on md files r=linter-reviewers,necko-reviewers,marco,jesup
Differential Revision: https://phabricator.services.mozilla.com/D165662
This commit is contained in:
@@ -56,4 +56,3 @@ It can also be useful for patch authors: if the changes comply with these guidel
|
|||||||
* R+: the code should land as soon as possible.
|
* R+: the code should land as soon as possible.
|
||||||
* R+ with comments: there are some comments, but they are minor enough, or don't require a new review once addressed, trust the author.
|
* R+ with comments: there are some comments, but they are minor enough, or don't require a new review once addressed, trust the author.
|
||||||
* R cancel / R- / F+: there is something wrong with the code, and a new review is required.
|
* R cancel / R- / F+: there is something wrong with the code, and a new review is required.
|
||||||
|
|
||||||
|
|||||||
@@ -7,4 +7,3 @@ We have pages defining standards, best practices and tips for various languages
|
|||||||
* [JavaScript](./javascript.md)
|
* [JavaScript](./javascript.md)
|
||||||
* [CSS](./css.md)
|
* [CSS](./css.md)
|
||||||
* [SVG](../frontend/svgs.md)
|
* [SVG](../frontend/svgs.md)
|
||||||
|
|
||||||
|
|||||||
@@ -128,4 +128,3 @@ The Mozilla way is to perform the toggle using an attribute rather than a class:
|
|||||||
|
|
||||||
* Use `:empty` to match a node that doesn't have children.
|
* Use `:empty` to match a node that doesn't have children.
|
||||||
* Usually, if `margin` or `padding` has 4 values, something is wrong. If the left and right values are asymmetrical, you're supposed to use `-start` and `-end`. If the values are symmetrical, use only 3 values (see localization section).
|
* Usually, if `margin` or `padding` has 4 values, something is wrong. If the left and right values are asymmetrical, you're supposed to use `-start` and `-end`. If the values are symmetrical, use only 3 values (see localization section).
|
||||||
|
|
||||||
|
|||||||
@@ -155,4 +155,3 @@ This should help you write eslint-clean code:
|
|||||||
* ESLint also runs on `<script>` tags in HTML files, so if you create new HTML test files for mochitests for example, make sure that JavaScript code in those files is free of ESLint errors.
|
* ESLint also runs on `<script>` tags in HTML files, so if you create new HTML test files for mochitests for example, make sure that JavaScript code in those files is free of ESLint errors.
|
||||||
* Depending on how a dependency is loaded into a file, the symbols this dependency exports might not be considered as defined by ESLint. For instance, using `Cu.import("some.jsm")` doesn't explicitly say which symbols are now available in the scope of the file, and so using those symbols will be consider by ESLint as using undefined variables. When this happens, please avoid using the `/* globals ... */` ESLint comment (which tells it that these variables are defined). Instead, please use `/* import-globals-from relative/path/to/file.js */`. This way, you won't have a list of variables to maintain manually, the globals are going to be imported dynamically instead.
|
* Depending on how a dependency is loaded into a file, the symbols this dependency exports might not be considered as defined by ESLint. For instance, using `Cu.import("some.jsm")` doesn't explicitly say which symbols are now available in the scope of the file, and so using those symbols will be consider by ESLint as using undefined variables. When this happens, please avoid using the `/* globals ... */` ESLint comment (which tells it that these variables are defined). Instead, please use `/* import-globals-from relative/path/to/file.js */`. This way, you won't have a list of variables to maintain manually, the globals are going to be imported dynamically instead.
|
||||||
* In test files (xpcshell and mochitest), all globals from the corresponding `head.js` file are imported automatically, so you don't need to define them using a `/* globals ... */` comment or a `/* import-globals-from head.js */` comment.
|
* In test files (xpcshell and mochitest), all globals from the corresponding `head.js` file are imported automatically, so you don't need to define them using a `/* globals ... */` comment or a `/* import-globals-from head.js */` comment.
|
||||||
|
|
||||||
|
|||||||
@@ -10,4 +10,3 @@ This page provides a very top level overview of what is on each directory in the
|
|||||||
* `devtools/client`: Code for the front-end side of our tools. In theory, each directory corresponds to a panel, but this is not always the case. This directory is only shipped with desktop Firefox, as opposed to other directories above, which are shipped with all Gecko products (Firefox for Android, etc.)
|
* `devtools/client`: Code for the front-end side of our tools. In theory, each directory corresponds to a panel, but this is not always the case. This directory is only shipped with desktop Firefox, as opposed to other directories above, which are shipped with all Gecko products (Firefox for Android, etc.)
|
||||||
* `devtools/client/locales`: Strings used in the client front-end.
|
* `devtools/client/locales`: Strings used in the client front-end.
|
||||||
* `devtools/client/themes`: CSS and images used in the client front-end.
|
* `devtools/client/themes`: CSS and images used in the client front-end.
|
||||||
|
|
||||||
|
|||||||
@@ -9,5 +9,3 @@ You will often hear about `actors`. Each feature that can be debugged (for examp
|
|||||||
Often, an actor will correspond to a panel. But a panel might want to get data from multiple actors.
|
Often, an actor will correspond to a panel. But a panel might want to get data from multiple actors.
|
||||||
|
|
||||||
You might also hear about `the toolbox`. The toolbox is what everyone else calls `developer tools` i.e. the front-end that you see when you open the tools in your browser.
|
You might also hear about `the toolbox`. The toolbox is what everyone else calls `developer tools` i.e. the front-end that you see when you open the tools in your browser.
|
||||||
|
|
||||||
|
|
||||||
|
|||||||
@@ -11,4 +11,3 @@ On the other hand, the repositories in `devtools-html` are more straightforward
|
|||||||
Even if you only want to work on a tool whose code is on `devtools-html`, you might still need to go through the step of getting and compiling the code from `mozilla-central` in order to do integration work (such as updating a tool bundle).
|
Even if you only want to work on a tool whose code is on `devtools-html`, you might still need to go through the step of getting and compiling the code from `mozilla-central` in order to do integration work (such as updating a tool bundle).
|
||||||
|
|
||||||
From now on, this guide will focus on building the full DevTools within Firefox. Please refer to individual project instructions for tools hosted in `devtools-html`.
|
From now on, this guide will focus on building the full DevTools within Firefox. Please refer to individual project instructions for tools hosted in `devtools-html`.
|
||||||
|
|
||||||
|
|||||||
@@ -11,4 +11,3 @@ To run a specific chrome mochitest:
|
|||||||
```bash
|
```bash
|
||||||
./mach mochitest devtools/path/to/the/test_you_want_to_run.html
|
./mach mochitest devtools/path/to/the/test_you_want_to_run.html
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -66,4 +66,3 @@ Then we can run our test with:
|
|||||||
```
|
```
|
||||||
./mach talos-test --suite damp --subtest inspector.click
|
./mach talos-test --suite damp --subtest inspector.click
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -142,4 +142,3 @@ Once it is done executing, the profile lives in a zip file you have to uncompres
|
|||||||
unzip testing/mozharness/build/blobber_upload_dir/profile_damp.zip
|
unzip testing/mozharness/build/blobber_upload_dir/profile_damp.zip
|
||||||
```
|
```
|
||||||
Then you have to open [https://profiler.firefox.com/](https://profiler.firefox.com/) and manually load the profile file that lives here: `profile_damp/page_0_pagecycle_1/cycle_0.profile`
|
Then you have to open [https://profiler.firefox.com/](https://profiler.firefox.com/) and manually load the profile file that lives here: `profile_damp/page_0_pagecycle_1/cycle_0.profile`
|
||||||
|
|
||||||
|
|||||||
@@ -235,4 +235,3 @@ In some cases, you may want to extract some common code from your test to use it
|
|||||||
* Use the special ESLint comment `/* import-globals-from helper_file.js */` to prevent ESLint errors for undefined variables.
|
* Use the special ESLint comment `/* import-globals-from helper_file.js */` to prevent ESLint errors for undefined variables.
|
||||||
|
|
||||||
In all cases, new helper functions should be properly commented with an jsdoc comment block.
|
In all cases, new helper functions should be properly commented with an jsdoc comment block.
|
||||||
|
|
||||||
|
|||||||
@@ -11,4 +11,3 @@ To run a specific xpcshell test:
|
|||||||
```bash
|
```bash
|
||||||
./mach xpcshell-test devtools/path/to/the/test_you_want_to_run.js
|
./mach xpcshell-test devtools/path/to/the/test_you_want_to_run.js
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -237,4 +237,3 @@ The algorithm explained above is tailored to the problem domain of `L10nRegistry
|
|||||||
It is important to maintain this guide up to date as any changes to the algorithm are to be made.
|
It is important to maintain this guide up to date as any changes to the algorithm are to be made.
|
||||||
|
|
||||||
Good luck.
|
Good luck.
|
||||||
|
|
||||||
|
|||||||
@@ -34,4 +34,3 @@ tail end of the prologue; subsequent lines comprise the operation;
|
|||||||
finally there is the beginning of the epilogue. Sometimes there is
|
finally there is the beginning of the epilogue. Sometimes there is
|
||||||
only the end of the prologue and the beginning of the operation, as
|
only the end of the prologue and the beginning of the operation, as
|
||||||
the operation is long and we don't care about its tail.
|
the operation is long and we don't care about its tail.
|
||||||
|
|
||||||
|
|||||||
@@ -10,4 +10,3 @@ The layout debugger can dump a variety of things including:
|
|||||||
## Usage
|
## Usage
|
||||||
- Use a debug build or add `ac_add_options --enable-layout-debugger` to your mozconfig.
|
- Use a debug build or add `ac_add_options --enable-layout-debugger` to your mozconfig.
|
||||||
- Run with `./mach run --layoutdebug [filename]`
|
- Run with `./mach run --layoutdebug [filename]`
|
||||||
|
|
||||||
|
|||||||
@@ -226,4 +226,3 @@ This reason is set when the DNS response contains NXDOMAIN rcode (0x03).
|
|||||||
Value: 31
|
Value: 31
|
||||||
|
|
||||||
This reason is set when the request was cancelled prior to completion.
|
This reason is set when the request was cancelled prior to completion.
|
||||||
|
|
||||||
|
|||||||
@@ -4,4 +4,3 @@ WebTransport
|
|||||||
Components:
|
Components:
|
||||||
|
|
||||||
- [WebTransportSessionProxy](webtransportsessionproxy.md)
|
- [WebTransportSessionProxy](webtransportsessionproxy.md)
|
||||||
|
|
||||||
|
|||||||
@@ -53,4 +53,3 @@ The following metrics are added to the ping:
|
|||||||
Data categories are [defined here](https://wiki.mozilla.org/Firefox/Data_Collection).
|
Data categories are [defined here](https://wiki.mozilla.org/Firefox/Data_Collection).
|
||||||
|
|
||||||
<!-- AUTOGENERATED BY glean_parser. DO NOT EDIT. -->
|
<!-- AUTOGENERATED BY glean_parser. DO NOT EDIT. -->
|
||||||
|
|
||||||
|
|||||||
@@ -62,4 +62,3 @@ After the config has been running as tier-2 makes it to beta and then to the rel
|
|||||||
* turn off the backstop jobs
|
* turn off the backstop jobs
|
||||||
|
|
||||||
This allows developers to schedule time in a 6 weeks period to investigate and fix any test failures.
|
This allows developers to schedule time in a 6 weeks period to investigate and fix any test failures.
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user