corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1528881 - Part 6: gfx/layers: Make some global functions static. r=mattwoodrow

Browse Source 
clang's -Wmissing-prototypes option identifies global functions that can be made static (because they're only called from one compilation unit) or removed (if they're never called).

gfx/layers/composite/ContainerLayerComposite.cpp:132:6 [-Wmissing-prototypes] no previous prototype for function 'TransformLayerGeometry'
gfx/layers/composite/LayerManagerComposite.cpp:1409:6 [-Wmissing-prototypes] no previous prototype for function 'ComputeVisibleRegionForChildren'
gfx/layers/composite/LayerManagerComposite.cpp:234:6 [-Wmissing-prototypes] no previous prototype for function 'ShouldProcessLayer'
gfx/layers/composite/TiledContentHost.cpp:156:6 [-Wmissing-prototypes] no previous prototype for function 'UseTileTexture'
gfx/layers/ipc/CompositorBridgeParent.cpp:1827:6 [-Wmissing-prototypes] no previous prototype for function 'EraseLayerState'
gfx/layers/ipc/CompositorBridgeParent.cpp:2140:6 [-Wmissing-prototypes] no previous prototype for function 'UpdateIndirectTree'
gfx/layers/opengl/OGLShaderProgram.cpp:28:6 [-Wmissing-prototypes] no previous prototype for function 'AddUniforms'

Differential Revision: https://phabricator.services.mozilla.com/D20265
This commit is contained in:
Chris Peterson
2019-02-17 14:25:01 -08:00
parent 39493c5123
commit 1e2a41a4c2
22 changed files with 71 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gfx/layers/opengl/OGLShaderProgram.cpp
View File

@@ -26,7 +26,7 @@ using namespace std;
#define GAUSSIAN_KERNEL_HALF_WIDTH 11
#define GAUSSIAN_KERNEL_STEP 0.2
void AddUniforms(ProgramProfileOGL &aProfile) {
static void AddUniforms(ProgramProfileOGL &aProfile) {
// This needs to be kept in sync with the KnownUniformName enum
static const char *sKnownUniformNames[] = {"uLayerTransform",
"uLayerTransformInverse",