From 1c93e269a3fca5d481674bddfe78c9901ab83b51 Mon Sep 17 00:00:00 2001 From: Wes Kocher Date: Mon, 20 Mar 2017 13:11:45 -0700 Subject: [PATCH] Bug 1341191 - ESlint followup a=bustage MozReview-Commit-ID: 4lDdvZoklM --- browser/base/content/browser-feeds.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/browser/base/content/browser-feeds.js b/browser/base/content/browser-feeds.js index 6f134236f262..3e95db0f130d 100644 --- a/browser/base/content/browser-feeds.js +++ b/browser/base/content/browser-feeds.js @@ -528,10 +528,7 @@ var FeedHandler = { // Ensure we have a pref that is settable if (aPrefName && SETTABLE_PREFS.has(aPrefName)) { if (aIsComplex) { - const supportsString = Cc["@mozilla.org/supports-string;1"]. - createInstance(Ci.nsISupportsString); - supportsString.data = aPrefValue; - Services.prefs.setComplexValue(aPrefName, Ci.nsISupportsString, supportsString); + Services.prefs.setStringPref(aPrefName, aPrefValue); } else { Services.prefs.setCharPref(aPrefName, aPrefValue); } @@ -551,7 +548,7 @@ var FeedHandler = { if (handler === "web") { try { - url = prefs.getComplexValue(getPrefWebForType(feedType), Ci.nsISupportsString).data; + url = prefs.getStringPref(getPrefWebForType(feedType)); } catch (ex) { LOG("FeedWriter._setSelectedHandler: invalid or no handler in prefs"); url = null;