Bug 1964753 - Update AGP to version 8.10.0. r=android-reviewers,mcarare

Differential Revision: https://phabricator.services.mozilla.com/D248090

gradle/libs.versions.toml

@@ -1,7 +1,7 @@
 [versions]
 # AGP
-android-gradle-plugin = "8.9.2" # Keep lint version in sync
-lint = "31.9.2"
+android-gradle-plugin = "8.10.0" # Keep lint version in sync
+lint = "31.10.0"
 
 python-envs-plugin = "0.0.31"
 maven-ant-tasks = "2.1.3"

mobile/android/android-components/components/browser/toolbar/src/main/java/mozilla/components/browser/toolbar/internal/ActionContainer.kt

@@ -14,6 +14,7 @@ import android.view.Gravity
 import android.view.View
 import android.widget.LinearLayout
 import androidx.annotation.VisibleForTesting
+import androidx.core.content.withStyledAttributes
 import androidx.core.view.isVisible
 import mozilla.components.browser.toolbar.R
 import mozilla.components.concept.toolbar.Toolbar
@@ -36,17 +37,15 @@ internal class ActionContainer @JvmOverloads constructor(
         orientation = HORIZONTAL
         visibility = View.GONE
 
-        context.obtainStyledAttributes(
+        context.withStyledAttributes(
             attrs,
             R.styleable.ActionContainer,
             defStyleAttr,
             0,
-        ).run {
+        ) {
             actionSize = attrs?.let {
                 getDimensionPixelSize(R.styleable.ActionContainer_actionContainerItemSize, 0)
             }
-
-            recycle()
         }
     }
 

mobile/android/android-components/components/feature/addons/src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt

@@ -188,6 +188,7 @@ class AddonsManagerAdapter(
         }
     }
 
+    @SuppressLint("RecyclerView")
     override fun onBindViewHolder(holder: CustomViewHolder, position: Int) {
         val item = getItem(position)
 

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/NotificationManager.kt

@@ -4,6 +4,7 @@
 
 package org.mozilla.fenix.components
 
+import android.annotation.SuppressLint
 import android.app.Notification
 import android.app.NotificationChannel
 import android.app.NotificationManager
@@ -64,6 +65,7 @@ class NotificationManager(private val context: Context) {
      * @param context The Android application context.
      * @param count The number of tabs that were closed.
      */
+    @SuppressLint("MissingPermission", "NotifyUsage")
     fun showSyncedTabsClosed(context: Context, count: Int) {
         if (count <= 0) {
             return
@@ -125,6 +127,14 @@ class NotificationManager(private val context: Context) {
         notificationManagerCompat.notify(TABS_CLOSED_TAG, notificationId, notification)
     }
 
+    /**
+     * Displays a notification for each valid tab received from a device.
+     *
+     * @param context The Android application context.
+     * @param device The device from which the tabs were received, or `null` if unavailable.
+     * @param tabs A list of tabs to be displayed.
+     */
+    @SuppressLint("MissingPermission", "NotifyUsage")
     fun showReceivedTabs(context: Context, device: Device?, tabs: List<TabData>) {
         // In the future, experiment with displaying multiple tabs from the same device as as Notification Groups.
         // For now, a single notification per tab received will suffice.

mobile/android/fenix/config/detekt-baseline.xml

@@ -797,7 +797,6 @@
     <ID>UndocumentedPublicFunction:NavController.kt$fun NavController.alreadyOnDestination(@IdRes destId: Int?): Boolean</ID>
     <ID>UndocumentedPublicFunction:NavController.kt$fun NavController.navigateSafe( @IdRes resId: Int, directions: NavDirections, )</ID>
     <ID>UndocumentedPublicFunction:NimbusBranchesView.kt$NimbusBranchesView$fun update(state: NimbusBranchesState)</ID>
-    <ID>UndocumentedPublicFunction:NotificationManager.kt$NotificationManager$fun showReceivedTabs(context: Context, device: Device?, tabs: List&lt;TabData&gt;)</ID>
     <ID>UndocumentedPublicFunction:PagerIndicator.kt$fun Context.dpToPx(value: Float): Int</ID>
     <ID>UndocumentedPublicFunction:PagerIndicator.kt$fun View.dpToPx(value: Float): Int</ID>
     <ID>UndocumentedPublicFunction:PasswordRevealHelper.kt$fun togglePasswordReveal(passwordText: TextView, revealPasswordButton: ImageButton)</ID>