corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm

Browse Source 
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
This commit is contained in:
Kan-Ru Chen
2016-11-15 04:26:00 +01:00
parent b4659e9e83
commit 1b9dd22e2d
404 changed files with 7108 additions and 6579 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp
View File

@@ -96,11 +96,11 @@ typedef map<uint64_t, CompositorBridgeParent::LayerTreeState> LayerTreeMap;
extern LayerTreeMap sIndirectLayerTrees;
extern StaticAutoPtr<mozilla::Monitor> sIndirectLayerTreesLock;
bool
mozilla::ipc::IPCResult
CrossProcessCompositorBridgeParent::RecvRequestNotifyAfterRemotePaint()
{
mNotifyAfterRemotePaint = true;
return true;
return IPC_OK();
}
void
@@ -164,20 +164,20 @@ CrossProcessCompositorBridgeParent::DeallocPLayerTransactionParent(PLayerTransac
return true;
}
bool
mozilla::ipc::IPCResult
CrossProcessCompositorBridgeParent::RecvAsyncPanZoomEnabled(const uint64_t& aLayersId, bool* aHasAPZ)
{
// Check to see if this child process has access to this layer tree.
if (!LayerTreeOwnerTracker::Get()->IsMapped(aLayersId, OtherPid())) {
NS_ERROR("Unexpected layers id in RecvAsyncPanZoomEnabled; dropping message...");
return false;
return IPC_FAIL_NO_REASON(this);
}
MonitorAutoLock lock(*sIndirectLayerTreesLock);
CompositorBridgeParent::LayerTreeState& state = sIndirectLayerTrees[aLayersId];
*aHasAPZ = state.mParent ? state.mParent->AsyncPanZoomEnabled() : false;
return true;
return IPC_OK();
}
PAPZCTreeManagerParent*
@@ -246,7 +246,7 @@ CrossProcessCompositorBridgeParent::DeallocPAPZParent(PAPZParent* aActor)
return true;
}
bool
mozilla::ipc::IPCResult
CrossProcessCompositorBridgeParent::RecvNotifyChildCreated(const uint64_t& child)
{
MonitorAutoLock lock(*sIndirectLayerTreesLock);
@@ -255,10 +255,10 @@ CrossProcessCompositorBridgeParent::RecvNotifyChildCreated(const uint64_t& child
CompositorBridgeParent::LayerTreeState* lts = &it->second;
if (lts->mParent && lts->mCrossProcessParent == this) {
lts->mParent->NotifyChildCreated(child);
return true;
return IPC_OK();
}
}
return false;
return IPC_FAIL_NO_REASON(this);
}
void
@@ -461,7 +461,7 @@ CrossProcessCompositorBridgeParent::GetCompositionManager(LayerTransactionParent
return state->mParent->GetCompositionManager(aLayerTree);
}
bool
mozilla::ipc::IPCResult
CrossProcessCompositorBridgeParent::RecvAcknowledgeCompositorUpdate(const uint64_t& aLayersId)
{
MonitorAutoLock lock(*sIndirectLayerTreesLock);
@@ -472,7 +472,7 @@ CrossProcessCompositorBridgeParent::RecvAcknowledgeCompositorUpdate(const uint64
}
MOZ_ASSERT(state.mPendingCompositorUpdates > 0);
state.mPendingCompositorUpdates--;
return true;
return IPC_OK();
}
void
@@ -531,7 +531,7 @@ CrossProcessCompositorBridgeParent::IsSameProcess() const
return OtherPid() == base::GetCurrentProcId();
}
bool
mozilla::ipc::IPCResult
CrossProcessCompositorBridgeParent::RecvClearApproximatelyVisibleRegions(const uint64_t& aLayersId,
const uint32_t& aPresShellId)
{
@@ -543,10 +543,10 @@ CrossProcessCompositorBridgeParent::RecvClearApproximatelyVisibleRegions(const u
if (parent) {
parent->ClearApproximatelyVisibleRegions(aLayersId, Some(aPresShellId));
}
return true;
return IPC_OK();
}
bool
mozilla::ipc::IPCResult
CrossProcessCompositorBridgeParent::RecvNotifyApproximatelyVisibleRegion(const ScrollableLayerGuid& aGuid,
const CSSIntRegion& aRegion)
{
@@ -556,9 +556,12 @@ CrossProcessCompositorBridgeParent::RecvNotifyApproximatelyVisibleRegion(const S
parent = sIndirectLayerTrees[aGuid.mLayersId].mParent;
}
if (parent) {
return parent->RecvNotifyApproximatelyVisibleRegion(aGuid, aRegion);
if (!parent->RecvNotifyApproximatelyVisibleRegion(aGuid, aRegion)) {
return IPC_FAIL_NO_REASON(this);
}
return IPC_OK();;
}
return true;
return IPC_OK();
}
void