Bug 1423913 P2 Make callers expect infallble CreateSource() and CreateHandle(). r=baku

2017-12-08 11:52:07 -05:00
parent 010f17975e
commit 1b9792a883
5 changed files with 8 additions and 19 deletions
--- a/docshell/base/nsDocShell.cpp
+++ b/docshell/base/nsDocShell.cpp
@@ -3442,9 +3442,7 @@ nsDocShell::MaybeCreateInitialClientSource(nsIPrincipal* aPrincipal)
    ClientManager::CreateSource(ClientType::Window,
                                win->EventTargetFor(TaskCategory::Other),
                                principal);
-  if (NS_WARN_IF(!mInitialClientSource)) {
-    return;
-  }
+  MOZ_DIAGNOSTIC_ASSERT(mInitialClientSource);

  // Mark the initial client as execution ready, but owned by the docshell.
  // If the client is actually used this will cause ClientSource to force