corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1959634 - Missing return after reject in SearchUtils.fetchIcon(). r=search-reviewers,scunnane

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D245043
This commit is contained in:
Moritz Beier
2025-04-14 11:08:22 +00:00
parent 28736c8d0c
commit 1b7eae0b6a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
toolkit/components/search/SearchUtils.sys.mjs
View File

@@ -492,12 +492,13 @@ export var SearchUtils = {
/** /**
* Fetches an icon without sending cookies to the page and returns * Fetches an icon without sending cookies to the page and returns
* the data and the mime type. Rejects if the icon cannot be fetched. * the data and the mime type.
* *
* @param {string|nsIURI} uri * @param {string|nsIURI} uri
* The URI to the icon. * The URI to the icon.
* @returns {Promise<[Uint8Array, string]>} * @returns {Promise<[Uint8Array, string]>}
* An array containing the data and the mime type. * Resolves to an array containing the data and the mime type.
* Rejects if the icon cannot be fetched.
*/ */
async fetchIcon(uri) { async fetchIcon(uri) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
@@ -507,7 +508,8 @@ export var SearchUtils = {
/^image\//, /^image\//,
(byteArray, contentType) => { (byteArray, contentType) => {
if (!byteArray) { if (!byteArray) {
reject(new Error("")); reject(new Error("Unable to fetch icon."));
return;
} }
resolve([Uint8Array.from(byteArray), contentType]); resolve([Uint8Array.from(byteArray), contentType]);
} }