corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 958714 part 3: Remove obsolete assertion & comment. r=mats

Browse Source 
MozReview-Commit-ID: jL2Xi4Okhb
This commit is contained in:
Daniel Holbert
2018-01-30 22:24:58 -05:00
parent 288ea66169
commit 1ad91dc5f9
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
layout/generic/ReflowInput.cpp
View File

@@ -156,11 +156,6 @@ FontSizeInflationListMarginAdjustment(const nsIFrame* aFrame)
return 0; return 0;
} }
// NOTE: If we ever want to use SizeComputationInput for a flex item or a
// grid item, we need to make it take the containing-block block-size as
// well as the inline-size, since flex items and grid items resolve
// block-direction percent margins and padding against the
// containing-block block-size, rather than its inline-size.
SizeComputationInput::SizeComputationInput(nsIFrame *aFrame, SizeComputationInput::SizeComputationInput(nsIFrame *aFrame,
gfxContext *aRenderingContext, gfxContext *aRenderingContext,
WritingMode aContainingBlockWritingMode, WritingMode aContainingBlockWritingMode,
@@ -169,12 +164,6 @@ SizeComputationInput::SizeComputationInput(nsIFrame *aFrame,
, mRenderingContext(aRenderingContext) , mRenderingContext(aRenderingContext)
, mWritingMode(aFrame->GetWritingMode()) , mWritingMode(aFrame->GetWritingMode())
{ {
MOZ_ASSERT(!aFrame->IsFlexOrGridItem(),
"We're about to resolve percent margin & padding "
"values against CB inline size, which is incorrect for "
"flex/grid items. "
"Additionally for grid items, this path doesn't handle baseline "
"padding contribution - see SizeComputationInput::InitOffsets");
ReflowInputFlags flags; ReflowInputFlags flags;
InitOffsets(aContainingBlockWritingMode, aContainingBlockISize, InitOffsets(aContainingBlockWritingMode, aContainingBlockISize,
mFrame->Type(), flags); mFrame->Type(), flags);