corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1060982 - Fix more bad implicit constructors in the HTML parser; r=hsivonen

Browse Source
This commit is contained in:
Ehsan Akhgari
2014-09-01 18:04:20 -04:00
parent 0bbb1df5e1
commit 1a06ad4b0d
6 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
parser/html/jArray.h
View File

@@ -23,6 +23,7 @@
#ifndef jArray_h #ifndef jArray_h
#define jArray_h #define jArray_h
#include "mozilla/Attributes.h"
#include "mozilla/NullPtr.h" #include "mozilla/NullPtr.h"
#include "nsDebug.h" #include "nsDebug.h"
@@ -77,7 +78,7 @@ class autoJArray {
, length(0) , length(0)
{ {
} }
autoJArray(const jArray<T,L>& other) MOZ_IMPLICIT autoJArray(const jArray<T,L>& other)
: arr(other.arr) : arr(other.arr)
, length(other.length) , length(other.length)
{ {

2
parser/html/nsHtml5AtomTable.h
View File

@@ -16,7 +16,7 @@ class nsHtml5Atom;
class nsHtml5AtomEntry : public nsStringHashKey class nsHtml5AtomEntry : public nsStringHashKey
{ {
public: public:
nsHtml5AtomEntry(KeyTypePointer aStr); explicit nsHtml5AtomEntry(KeyTypePointer aStr);
nsHtml5AtomEntry(const nsHtml5AtomEntry& aOther); nsHtml5AtomEntry(const nsHtml5AtomEntry& aOther);
~nsHtml5AtomEntry(); ~nsHtml5AtomEntry();
inline nsHtml5Atom* GetAtom() inline nsHtml5Atom* GetAtom()

2
parser/html/nsHtml5DocumentBuilder.h
View File

@@ -107,7 +107,7 @@ public:
protected: protected:
nsHtml5DocumentBuilder(bool aRunsToCompletion); explicit nsHtml5DocumentBuilder(bool aRunsToCompletion);
virtual ~nsHtml5DocumentBuilder(); virtual ~nsHtml5DocumentBuilder();
protected: protected:

4
parser/html/nsHtml5OwningUTF16Buffer.h
View File

@@ -14,7 +14,7 @@ class nsHtml5OwningUTF16Buffer : public nsHtml5UTF16Buffer
/** /**
* Passes a buffer and its length to the superclass constructor. * Passes a buffer and its length to the superclass constructor.
*/ */
nsHtml5OwningUTF16Buffer(char16_t* aBuffer); explicit nsHtml5OwningUTF16Buffer(char16_t* aBuffer);
public: public:
@@ -22,7 +22,7 @@ class nsHtml5OwningUTF16Buffer : public nsHtml5UTF16Buffer
* Constructor for a parser key placeholder. (No actual buffer.) * Constructor for a parser key placeholder. (No actual buffer.)
* @param aKey a parser key * @param aKey a parser key
*/ */
nsHtml5OwningUTF16Buffer(void* aKey); explicit nsHtml5OwningUTF16Buffer(void* aKey);
protected: protected:
/** /**

6
parser/html/nsHtml5RefPtr.h
View File

@@ -14,7 +14,7 @@ class nsHtml5RefPtrReleaser : public nsRunnable
private: private:
T* mPtr; T* mPtr;
public: public:
nsHtml5RefPtrReleaser(T* aPtr) explicit nsHtml5RefPtrReleaser(T* aPtr)
: mPtr(aPtr) : mPtr(aPtr)
{} {}
NS_IMETHODIMP Run() NS_IMETHODIMP Run()
@@ -97,7 +97,7 @@ class nsHtml5RefPtr
mRawPtr->AddRef(); mRawPtr->AddRef();
} }
nsHtml5RefPtr( T* aRawPtr ) explicit nsHtml5RefPtr( T* aRawPtr )
: mRawPtr(aRawPtr) : mRawPtr(aRawPtr)
// construct from a raw pointer (of the right type) // construct from a raw pointer (of the right type)
{ {
@@ -105,7 +105,7 @@ class nsHtml5RefPtr
mRawPtr->AddRef(); mRawPtr->AddRef();
} }
nsHtml5RefPtr( const already_AddRefed<T>& aSmartPtr ) explicit nsHtml5RefPtr( const already_AddRefed<T>& aSmartPtr )
: mRawPtr(aSmartPtr.mRawPtr) : mRawPtr(aSmartPtr.mRawPtr)
// construct from |dont_AddRef(expr)| // construct from |dont_AddRef(expr)|
{ {

2
parser/html/nsHtml5StreamListener.h
View File

@@ -32,7 +32,7 @@ class nsHtml5StreamListener : public nsIStreamListener,
public nsIThreadRetargetableStreamListener public nsIThreadRetargetableStreamListener
{ {
public: public:
nsHtml5StreamListener(nsHtml5StreamParser* aDelegate); explicit nsHtml5StreamListener(nsHtml5StreamParser* aDelegate);
NS_DECL_THREADSAFE_ISUPPORTS NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIREQUESTOBSERVER NS_DECL_NSIREQUESTOBSERVER