Bug 684096 - "The webconsole should display column numbers in addition to line numbers". c=mdibaiee

This commit is contained in:
Mahdi Dibaiee
2014-11-05 05:43:00 +01:00
parent b4dfc1b31c
commit 174ef3cdd4
7 changed files with 125 additions and 38 deletions

View File

@@ -943,14 +943,16 @@ Messages.Simple.prototype = Heritage.extend(Messages.BaseMessage.prototype,
return null;
}
let {url, line} = this.location;
let {url, line, column} = this.location;
if (IGNORED_SOURCE_URLS.indexOf(url) != -1) {
return null;
}
// The ConsoleOutput owner is a WebConsoleFrame instance from webconsole.js.
// TODO: move createLocationNode() into this file when bug 778766 is fixed.
return this.output.owner.createLocationNode(url, line);
return this.output.owner.createLocationNode({url: url,
line: line,
column: column});
},
}); // Messages.Simple.prototype
@@ -1250,6 +1252,7 @@ Messages.ConsoleGeneric = function(packet)
location: {
url: packet.filename,
line: packet.lineNumber,
column: packet.columnNumber
},
};
@@ -3446,8 +3449,8 @@ Widgets.Stacktrace.prototype = Heritage.extend(Widgets.BaseWidget.prototype,
fn.textContent = l10n.getStr("stacktrace.anonymousFunction");
}
let location = this.output.owner.createLocationNode(frame.filename,
frame.lineNumber,
let location = this.output.owner.createLocationNode({url: frame.filename,
line: frame.lineNumber},
"jsdebugger");
// .devtools-monospace sets font-size to 80%, however .body already has