corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/search r=search-reviewers,jteow

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D246153
This commit is contained in:
Beth Rennie
2025-04-30 03:22:10 +00:00
parent 8006dae1c0
commit 17349abf86
1 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
browser/components/search/SERPCategorization.sys.mjs
View File

@@ -11,7 +11,7 @@ import { XPCOMUtils } from "resource://gre/modules/XPCOMUtils.sys.mjs";
const lazy = {}; const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, { ChromeUtils.defineESModuleGetters(lazy, {
ExperimentAPI: "resource://nimbus/ExperimentAPI.sys.mjs", EnrollmentType: "resource://nimbus/ExperimentAPI.sys.mjs",
NimbusFeatures: "resource://nimbus/ExperimentAPI.sys.mjs", NimbusFeatures: "resource://nimbus/ExperimentAPI.sys.mjs",
Region: "resource://gre/modules/Region.sys.mjs", Region: "resource://gre/modules/Region.sys.mjs",
RemoteSettings: "resource://services-settings/remote-settings.sys.mjs", RemoteSettings: "resource://services-settings/remote-settings.sys.mjs",
@@ -516,26 +516,25 @@ class CategorizationRecorder {
lazy.logConsole.debug("Found targetExperiment:", targetExperiment); lazy.logConsole.debug("Found targetExperiment:", targetExperiment);
// Try checking if an Experiment exists, otherwise check for a Rollout. let metadata = lazy.NimbusFeatures.search.getEnrollmentMetadata(
let metadata = lazy.EnrollmentType.EXPERIMENT
lazy.ExperimentAPI.getExperimentMetaData({ );
featureId: "search", if (metadata?.slug !== targetExperiment) {
slug: targetExperiment, metadata = lazy.NimbusFeatures.search.getEnrollmentMetadata(
}) ?? lazy.EnrollmentType.ROLLOUT
lazy.ExperimentAPI.getRolloutMetaData({ );
featureId: "search",
slug: targetExperiment, if (metadata?.slug !== targetExperiment) {
});
if (!metadata) {
lazy.logConsole.debug( lazy.logConsole.debug(
"No experiment or rollout found that matches targetExperiment." "No experiment or rollout found that matches targetExperiment."
); );
return; return;
} }
}
let experimentToRecord = { let experimentToRecord = {
slug: metadata.slug, slug: metadata.slug,
branch: metadata.branch?.slug, branch: metadata.branch,
}; };
lazy.logConsole.debug("Experiment data:", experimentToRecord); lazy.logConsole.debug("Experiment data:", experimentToRecord);
Glean.serp.experimentInfo.set(experimentToRecord); Glean.serp.experimentInfo.set(experimentToRecord);