corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1372510 - Exclude 'job' tasks that require a build from the default try selection, r=dustin

Browse Source 
It's a bit hacky to single out 'build' dependencies, but most tasks have a dependency on a docker
image, so we can't blanket skip all 'job' tasks with any dependencies at all. This is far from ideal
but is an improvement on the current behaviour of running build dependencies all the time, even if
the 'job' task gets optimized away.

There is likely a cleverer solution, but that can be follow-up work.

MozReview-Commit-ID: 6T68LT5VSrg
This commit is contained in:
Andrew Halberstadt
2017-06-13 11:04:08 -04:00
parent a47b77823f
commit 16f7b57cf3
3 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
taskcluster/taskgraph/try_option_syntax.py
View File

@@ -548,8 +548,8 @@ class TryOptionSyntax(object):
rv.add(a[len(prefix):])
return sorted(rv)
def task_matches(self, attributes):
attr = attributes.get
def task_matches(self, task):
attr = task.attributes.get
def check_run_on_projects():
if attr('nightly') and not self.include_nightly:
@@ -574,7 +574,7 @@ class TryOptionSyntax(object):
else:
return False
if 'platforms' in test:
platform = attributes.get('test_platform', '').split('/')[0]
platform = attr('test_platform', '').split('/')[0]
if platform not in test['platforms']:
return False
if 'only_chunks' in test and attr('test_chunk') not in test['only_chunks']:
@@ -588,6 +588,12 @@ class TryOptionSyntax(object):
# they remained unspecified.
if self.jobs and job_try_name not in self.jobs:
return False
elif not self.jobs and 'build' in task.dependencies:
# We exclude tasks with build dependencies from the default set of jobs because
# they will schedule their builds even if they end up optimized away. This means
# to run these tasks on try, they'll need to be explicitly specified by -j until
# we find a better solution (see bug 1372510).
return False
elif not self.jobs and attr('build_platform'):
if self.platforms is None or attr('build_platform') in self.platforms:
return True