corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1372268 - Use LookupForAdd instead of Get+Put to avoid unnecessary hashtable lookups. r=froydnj

Browse Source 
MozReview-Commit-ID: 1WVLTschGsj
This commit is contained in:
Mats Palmgren
2017-06-14 16:11:22 +02:00
parent 755ea361d0
commit 15d95588ce
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/commandhandler/nsCommandManager.cpp
View File

@@ -102,11 +102,9 @@ nsCommandManager::AddCommandObserver(nsIObserver* aCommandObserver,
// XXX todo: handle special cases of aCommandToObserve being null, or empty
// for each command in the table, we make a list of observers for that command
ObserverList* commandObservers;
if (!mObserversTable.Get(aCommandToObserve, &commandObservers)) {
commandObservers = new ObserverList;
mObserversTable.Put(aCommandToObserve, commandObservers);
}
ObserverList* commandObservers =
mObserversTable.LookupForAdd(aCommandToObserve).OrInsert(
[] () { return new ObserverList; });
// need to check that this command observer hasn't already been registered
int32_t existingIndex = commandObservers->IndexOf(aCommandObserver);