Bug 1246869 - remove services.sync.syncedTabsUIRefresh preference so SyncedTabs sidebar can ride the trains. r=adw

browser/app/profile/firefox.js

@@ -1328,12 +1328,6 @@ pref("services.sync.prefs.sync.signon.rememberSignons", true);
 pref("services.sync.prefs.sync.spellchecker.dictionary", true);
 pref("services.sync.prefs.sync.xpinstall.whitelist.required", true);
 
-#ifdef NIGHTLY_BUILD
-pref("services.sync.syncedTabsUIRefresh", true);
-#else
-pref("services.sync.syncedTabsUIRefresh", false);
-#endif
-
 // A preference that controls whether we should show the icon for a remote tab.
 // This pref has no UI but exists because some people may be concerned that
 // fetching these icons to show remote tabs may leak information about that

browser/base/content/browser-sets.inc

@@ -190,7 +190,6 @@
     <broadcaster id="sync-reauth-state" hidden="true"/>
     <broadcaster id="viewTabsSidebar" autoCheck="false" sidebartitle="&syncedTabs.sidebar.label;"
                  type="checkbox" group="sidebar"
-                 hidden="true"
                  sidebarurl="chrome://browser/content/syncedtabs/sidebar.xhtml"
                  oncommand="SidebarUI.toggle('viewTabsSidebar');"/>
     <broadcaster id="workOfflineMenuitemState"/>

browser/base/content/browser-syncui.js

@@ -81,12 +81,6 @@ var gSyncUI = {
     let broadcaster = document.getElementById("sync-status");
     broadcaster.setAttribute("label", this._stringBundle.GetStringFromName("syncnow.label"));
 
-    // Initialize the Synced Tabs Sidebar
-    if (Services.prefs.getBoolPref("services.sync.syncedTabsUIRefresh")) {
-      let sidebarBroadcaster = document.getElementById("viewTabsSidebar");
-      sidebarBroadcaster.removeAttribute("hidden");
-    }
-
     this.maybeMoveSyncedTabsButton();
 
     this.updateUI();

browser/base/content/browser.js

@@ -6452,11 +6452,7 @@ function checkEmptyPageOrigin(browser = gBrowser.selectedBrowser,
 }
 
 function BrowserOpenSyncTabs() {
-  if (Services.prefs.getBoolPref("services.sync.syncedTabsUIRefresh")) {
   gSyncUI.openSyncedTabsPanel();
-  } else {
-    switchToTabHavingURI("about:sync-tabs", true);
-  }
 }
 
 /**