Fixing dereferencing null-pointer. Caused crash, #14496

1999-10-01 20:10:39 +00:00
parent a1381d3926
commit 1543f96cf4
3 changed files with 21 additions and 12 deletions
--- a/modules/plugin/base/src/nsPluginViewer.cpp
+++ b/modules/plugin/base/src/nsPluginViewer.cpp
@@ -620,14 +620,17 @@ PluginListener::OnStartRequest(nsIURI* aURL, const char *contentType)
    return rv;
  }
  rv = mViewer->StartLoad(channel, mNextStream);
-  NS_RELEASE(channel);
-  if (NS_FAILED(rv)) return rv;
+
+  if (NS_FAILED(rv))
+  {
+    NS_RELEASE(channel);
+    return rv;
+  }
 #else
  mViewer->StartLoad(aURL, contentType, mNextStream);
 #endif
-  if (nsnull == mNextStream) {
+  if (nsnull == mNextStream) 
    return NS_ERROR_FAILURE;
-  }
 #ifdef NECKO
  return mNextStream->OnStartRequest(channel, ctxt);
 #else