corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1959352 - Make WhiteSpaceVisibilityKeeper::NormalizeWhiteSpacesToSplitTextNodeAt() return end of its parent when it deletes a last Text r=m_kato

Browse Source 
I'm not sure how to make this appear as an unexpected result. I just found
these mistakes when I was debugging bug 1959323

Depends on D244876

Differential Revision: https://phabricator.services.mozilla.com/D244879
This commit is contained in:
Masayuki Nakano
2025-04-12 23:50:26 +00:00
parent d994f7392e
commit 144cd4c4ad
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/libeditor/WhiteSpaceVisibilityKeeper.cpp
View File

@@ -1419,7 +1419,8 @@ WhiteSpaceVisibilityKeeper::NormalizeWhiteSpacesToSplitTextNodeAt(
if (NS_WARN_IF(nextSibling && nextSibling->GetParentNode() != parentNode)) { if (NS_WARN_IF(nextSibling && nextSibling->GetParentNode() != parentNode)) {
return Err(NS_ERROR_EDITOR_UNEXPECTED_DOM_TREE); return Err(NS_ERROR_EDITOR_UNEXPECTED_DOM_TREE);
} }
return EditorDOMPoint(nextSibling); return nextSibling ? EditorDOMPoint(nextSibling)
: EditorDOMPoint::AtEndOf(*parentNode);
} }
const HTMLEditor::ReplaceWhiteSpacesData replacePrecedingWhiteSpacesData = const HTMLEditor::ReplaceWhiteSpacesData replacePrecedingWhiteSpacesData =
@@ -1461,7 +1462,8 @@ WhiteSpaceVisibilityKeeper::NormalizeWhiteSpacesToSplitTextNodeAt(
if (NS_WARN_IF(nextSibling && nextSibling->GetParentNode() != parentNode)) { if (NS_WARN_IF(nextSibling && nextSibling->GetParentNode() != parentNode)) {
return Err(NS_ERROR_EDITOR_UNEXPECTED_DOM_TREE); return Err(NS_ERROR_EDITOR_UNEXPECTED_DOM_TREE);
} }
return EditorDOMPoint(nextSibling); return nextSibling ? EditorDOMPoint(nextSibling)
: EditorDOMPoint::AtEndOf(*parentNode);
} }
Result<InsertTextResult, nsresult> replaceWhiteSpacesResultOrError = Result<InsertTextResult, nsresult> replaceWhiteSpacesResultOrError =
aHTMLEditor.ReplaceTextWithTransaction(textNode, replaceWhiteSpacesData); aHTMLEditor.ReplaceTextWithTransaction(textNode, replaceWhiteSpacesData);