corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1688948 - Only allow BrowsingContext's TouchEventsOverrideInternal to be set from the parent process; r=nika

Browse Source 
devtool only set it in parent process after bug 1704733.

Differential Revision: https://phabricator.services.mozilla.com/D116374
This commit is contained in:
Edgar Chen
2021-05-31 16:53:55 +00:00
parent 02510c5cb7
commit 126d1f82b2
5 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docshell/base/BrowsingContext.cpp
View File

@@ -2613,9 +2613,8 @@ bool BrowsingContext::InactiveForSuspend() const {
}
bool BrowsingContext::CanSet(FieldIndex<IDX_TouchEventsOverrideInternal>,
dom::TouchEventsOverride, ContentParent*) {
// TODO: Bug 1688948 - Should only be set in the parent process.
return true;
dom::TouchEventsOverride, ContentParent* aSource) {
return XRE_IsParentProcess() && !aSource;
}
void BrowsingContext::DidSet(FieldIndex<IDX_PrefersColorSchemeOverride>,
@@ -2873,11 +2872,6 @@ mozilla::dom::TouchEventsOverride BrowsingContext::TouchEventsOverride() const {
return mozilla::dom::TouchEventsOverride::None;
}
void BrowsingContext::SetTouchEventsOverride(dom::TouchEventsOverride aOverride,
ErrorResult& aRv) {
SetTouchEventsOverrideInternal(aOverride, aRv);
}
// We map `watchedByDevTools` WebIDL attribute to `watchedByDevToolsInternal`
// BC field. And we map it to the top level BrowsingContext.
bool BrowsingContext::WatchedByDevTools() {