corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1020609 - Inherit property descriptor attributes for pre-existing own value props in Proxy::set. r=efaust

Browse Source
This commit is contained in:
Bobby Holley
2014-06-11 15:16:06 -07:00
parent a1224afe5e
commit 1205082275
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
js/src/jsproxy.cpp
View File

@@ -2454,9 +2454,16 @@ Proxy::set(JSContext *cx, HandleObject proxy, HandleObject receiver, HandleId id
// Ok. Either there was no pre-existing property, or it was a value prop
// that we're going to shadow. Make a property descriptor and define it.
//
// Note that for pre-existing own value properties, we inherit the existing
// attributes, since we're really just changing the value and not trying to
// reconfigure the property.
Rooted<PropertyDescriptor> newDesc(cx);
if (desc.object() == proxy)
newDesc.setAttributes(desc.attributes());
else
newDesc.setAttributes(JSPROP_ENUMERATE);
newDesc.value().set(vp);
newDesc.setAttributes(JSPROP_ENUMERATE);
return handler->defineProperty(cx, receiver, id, &newDesc);
}