corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1357207 - Caching duration recorded to telemetry should be milli-second . r=francois

Browse Source 
In Bug 1311935, We change positive/negative cache duration from milli-second to second.
But the value doesn't covert back to milli-second when store to telemetry(telemetry use
milli-second).

MozReview-Commit-ID: KR6xn9pwhUd
This commit is contained in:
DimiL
2017-04-18 12:01:09 +08:00
parent 2ac016ce46
commit 11fae5a35a
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
toolkit/components/url-classifier/nsUrlClassifierUtils.cpp
View File

@@ -459,24 +459,24 @@ nsUrlClassifierUtils::ParseFindFullHashResponseV4(const nsACString& aResponse,
continue; // Ignore un-convertable threat type.
}
auto& hash = m.threat().hash();
auto cacheDuration = m.cache_duration().seconds();
auto cacheDurationSec = m.cache_duration().seconds();
aCallback->OnCompleteHashFound(nsCString(hash.c_str(), hash.length()),
tableNames, cacheDuration);
tableNames, cacheDurationSec);
Telemetry::Accumulate(Telemetry::URLCLASSIFIER_POSITIVE_CACHE_DURATION,
cacheDuration);
cacheDurationSec * PR_MSEC_PER_SEC);
}
auto minWaitDuration = DurationToMs(r.minimum_wait_duration());
auto negCacheDuration = r.negative_cache_duration().seconds();
auto negCacheDurationSec = r.negative_cache_duration().seconds();
aCallback->OnResponseParsed(minWaitDuration, negCacheDuration);
aCallback->OnResponseParsed(minWaitDuration, negCacheDurationSec);
Telemetry::Accumulate(Telemetry::URLCLASSIFIER_COMPLETION_ERROR,
hasUnknownThreatType ? UNKNOWN_THREAT_TYPE : SUCCESS);
Telemetry::Accumulate(Telemetry::URLCLASSIFIER_NEGATIVE_CACHE_DURATION,
negCacheDuration);
negCacheDurationSec * PR_MSEC_PER_SEC);
return NS_OK;
}