corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 879079 - Make ToNumber take a Handle to fix some static rooting analysis failures; r=sfink

Browse Source
This commit is contained in:
Terrence Cole
2013-06-21 18:19:11 -07:00
parent d98ea6ad32
commit 11f8ce8af5
13 changed files with 83 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
js/src/jsdate.cpp
View File

@@ -614,7 +614,7 @@ date_msecFromArgs(JSContext *cx, CallArgs args, double *rval)
for (loop = 0; loop < MAXARGS; loop++) {
if (loop < args.length()) {
double d;
if (!ToNumber(cx, args[loop], &d))
if (!ToNumber(cx, args.handleAt(loop), &d))
return JS_FALSE;
/* return NaN if any arg is not finite */
if (!IsFinite(d)) {
@@ -1714,7 +1714,7 @@ date_setTime_impl(JSContext *cx, CallArgs args)
}
double result;
if (!ToNumber(cx, args[0], &result))
if (!ToNumber(cx, args.handleAt(0), &result))
return false;
dateObj->setUTCTime(TimeClip(result), args.rval().address());
@@ -1735,7 +1735,7 @@ GetMsecsOrDefault(JSContext *cx, const CallArgs &args, unsigned i, double t, dou
*millis = msFromTime(t);
return true;
}
return ToNumber(cx, args[i], millis);
return ToNumber(cx, args.handleAt(i), millis);
}
static bool
@@ -1745,7 +1745,7 @@ GetSecsOrDefault(JSContext *cx, const CallArgs &args, unsigned i, double t, doub
*sec = SecFromTime(t);
return true;
}
return ToNumber(cx, args[i], sec);
return ToNumber(cx, args.handleAt(i), sec);
}
static bool
@@ -1755,7 +1755,7 @@ GetMinsOrDefault(JSContext *cx, const CallArgs &args, unsigned i, double t, doub
*mins = MinFromTime(t);
return true;
}
return ToNumber(cx, args[i], mins);
return ToNumber(cx, args.handleAt(i), mins);
}
/* ES5 15.9.5.28. */
@@ -1769,7 +1769,7 @@ date_setMilliseconds_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double milli;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &milli))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &milli))
return false;
double time = MakeTime(HourFromTime(t), MinFromTime(t), SecFromTime(t), milli);
@@ -1799,7 +1799,7 @@ date_setUTCMilliseconds_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double milli;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &milli))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &milli))
return false;
double time = MakeTime(HourFromTime(t), MinFromTime(t), SecFromTime(t), milli);
@@ -1829,7 +1829,7 @@ date_setSeconds_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double s;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &s))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &s))
return false;
/* Step 3. */
@@ -1866,7 +1866,7 @@ date_setUTCSeconds_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double s;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &s))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &s))
return false;
/* Step 3. */
@@ -1903,7 +1903,7 @@ date_setMinutes_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double m;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &m))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &m))
return false;
/* Step 3. */
@@ -1945,7 +1945,7 @@ date_setUTCMinutes_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double m;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &m))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &m))
return false;
/* Step 3. */
@@ -1987,7 +1987,7 @@ date_setHours_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double h;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &h))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &h))
return false;
/* Step 3. */
@@ -2034,7 +2034,7 @@ date_setUTCHours_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double h;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &h))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &h))
return false;
/* Step 3. */
@@ -2081,7 +2081,7 @@ date_setDate_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double date;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &date))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &date))
return false;
/* Step 3. */
@@ -2113,7 +2113,7 @@ date_setUTCDate_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double date;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &date))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &date))
return false;
/* Step 3. */
@@ -2141,7 +2141,7 @@ GetDateOrDefault(JSContext *cx, const CallArgs &args, unsigned i, double t, doub
*date = DateFromTime(t);
return true;
}
return ToNumber(cx, args[i], date);
return ToNumber(cx, args.handleAt(i), date);
}
static bool
@@ -2151,7 +2151,7 @@ GetMonthOrDefault(JSContext *cx, const CallArgs &args, unsigned i, double t, dou
*month = MonthFromTime(t);
return true;
}
return ToNumber(cx, args[i], month);
return ToNumber(cx, args.handleAt(i), month);
}
/* ES5 15.9.5.38. */
@@ -2165,7 +2165,7 @@ date_setMonth_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double m;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &m))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &m))
return false;
/* Step 3. */
@@ -2202,7 +2202,7 @@ date_setUTCMonth_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double m;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &m))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &m))
return false;
/* Step 3. */
@@ -2255,7 +2255,7 @@ date_setFullYear_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double y;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &y))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &y))
return false;
/* Step 3. */
@@ -2297,7 +2297,7 @@ date_setUTCFullYear_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double y;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &y))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &y))
return false;
/* Step 3. */
@@ -2339,7 +2339,7 @@ date_setYear_impl(JSContext *cx, CallArgs args)
/* Step 2. */
double y;
if (!ToNumber(cx, args.length() > 0 ? args[0] : UndefinedValue(), &y))
if (!ToNumber(cx, args.handleOrUndefinedAt(0), &y))
return false;
/* Step 3. */
@@ -3003,7 +3003,7 @@ js_Date(JSContext *cx, unsigned argc, Value *vp)
d = TimeClip(d);
} else {
/* Step 3. */
if (!ToNumber(cx, args[0], &d))
if (!ToNumber(cx, args.handleAt(0), &d))
return false;
d = TimeClip(d);
}