From 11c4b51a67d753bc22d49f7bd80adf2b10fe2c6e Mon Sep 17 00:00:00 2001 From: Tooru Fujisawa Date: Sun, 11 Sep 2016 18:15:24 +0900 Subject: [PATCH] Bug 1290337 - Part 16: Replace Value parameter to const Value& in dom. r=smaug --- dom/canvas/CanvasUtils.cpp | 2 +- dom/canvas/CanvasUtils.h | 2 +- dom/plugins/base/nsJSNPRuntime.cpp | 2 +- dom/plugins/base/nsJSNPRuntime.h | 2 +- dom/workers/WorkerPrivate.cpp | 2 +- dom/workers/Workers.h | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dom/canvas/CanvasUtils.cpp b/dom/canvas/CanvasUtils.cpp index ac0e2684947c..c7cfed83f65d 100644 --- a/dom/canvas/CanvasUtils.cpp +++ b/dom/canvas/CanvasUtils.cpp @@ -112,7 +112,7 @@ DoDrawImageSecurityCheck(dom::HTMLCanvasElement *aCanvasElement, } bool -CoerceDouble(JS::Value v, double* d) +CoerceDouble(const JS::Value& v, double* d) { if (v.isDouble()) { *d = v.toDouble(); diff --git a/dom/canvas/CanvasUtils.h b/dom/canvas/CanvasUtils.h index cc4b65e79377..a69b8bd72973 100644 --- a/dom/canvas/CanvasUtils.h +++ b/dom/canvas/CanvasUtils.h @@ -49,7 +49,7 @@ void DoDrawImageSecurityCheck(dom::HTMLCanvasElement *aCanvasElement, // Make a double out of |v|, treating undefined values as 0.0 (for // the sake of sparse arrays). Return true iff coercion // succeeded. -bool CoerceDouble(JS::Value v, double* d); +bool CoerceDouble(const JS::Value& v, double* d); /* Float validation stuff */ #define VALIDATE(_f) if (!IsFinite(_f)) return false diff --git a/dom/plugins/base/nsJSNPRuntime.cpp b/dom/plugins/base/nsJSNPRuntime.cpp index 2465457761d7..020cffd4e69c 100644 --- a/dom/plugins/base/nsJSNPRuntime.cpp +++ b/dom/plugins/base/nsJSNPRuntime.cpp @@ -539,7 +539,7 @@ NPVariantToJSVal(NPP npp, JSContext *cx, const NPVariant *variant) } bool -JSValToNPVariant(NPP npp, JSContext *cx, JS::Value val, NPVariant *variant) +JSValToNPVariant(NPP npp, JSContext *cx, const JS::Value& val, NPVariant *variant) { NS_ASSERTION(npp, "Must have an NPP to wrap a jsval!"); diff --git a/dom/plugins/base/nsJSNPRuntime.h b/dom/plugins/base/nsJSNPRuntime.h index 355d6e23af34..871988e06899 100644 --- a/dom/plugins/base/nsJSNPRuntime.h +++ b/dom/plugins/base/nsJSNPRuntime.h @@ -102,7 +102,7 @@ public: }; bool -JSValToNPVariant(NPP npp, JSContext *cx, JS::Value val, NPVariant *variant); +JSValToNPVariant(NPP npp, JSContext *cx, const JS::Value& val, NPVariant *variant); #endif // nsJSNPRuntime_h_ diff --git a/dom/workers/WorkerPrivate.cpp b/dom/workers/WorkerPrivate.cpp index f3d3e52eab75..1635a6663fa6 100644 --- a/dom/workers/WorkerPrivate.cpp +++ b/dom/workers/WorkerPrivate.cpp @@ -6655,7 +6655,7 @@ EventTarget::IsOnCurrentThread(bool* aIsOnCurrentThread) BEGIN_WORKERS_NAMESPACE WorkerCrossThreadDispatcher* -GetWorkerCrossThreadDispatcher(JSContext* aCx, JS::Value aWorker) +GetWorkerCrossThreadDispatcher(JSContext* aCx, const JS::Value& aWorker) { if (!aWorker.isObject()) { return nullptr; diff --git a/dom/workers/Workers.h b/dom/workers/Workers.h index dd3b2bac3a03..89e2ccfca6e6 100644 --- a/dom/workers/Workers.h +++ b/dom/workers/Workers.h @@ -348,7 +348,7 @@ public: }; WorkerCrossThreadDispatcher* -GetWorkerCrossThreadDispatcher(JSContext* aCx, JS::Value aWorker); +GetWorkerCrossThreadDispatcher(JSContext* aCx, const JS::Value& aWorker); // Random unique constant to facilitate JSPrincipal debugging const uint32_t kJSPrincipalsDebugToken = 0x7e2df9d2;