servo: Merge #13986 - Make test-tidy check for alphabetical ordering of #![feature(...)] statements (from iamrohit7:tidy-feature-attrs); r=Wafflespeanut
<!-- Please describe your changes on the following line: --> <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #13954 (github issue number if applicable). <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 291f393723d22a582bb9a49ef7294ec14eca2127
This commit is contained in:
14
servo/python/tidy/servo_tidy_tests/lib.rs
Normal file
14
servo/python/tidy/servo_tidy_tests/lib.rs
Normal file
@@ -0,0 +1,14 @@
|
||||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||
|
||||
#![feature(def)]
|
||||
#![feature(abc)]
|
||||
|
||||
#![feature(abc, def, ghi)]
|
||||
#![feature(aaa)]
|
||||
|
||||
#![feature(def, ghi, abc)]
|
||||
|
||||
#![feature(ghi)]
|
||||
#![feature(abd, hef)]
|
||||
@@ -127,6 +127,14 @@ class CheckTidiness(unittest.TestCase):
|
||||
self.assertEqual('extra space after test_fun', errors.next()[2])
|
||||
self.assertNoMoreErrors(errors)
|
||||
|
||||
feature_errors = tidy.collect_errors_for_files(iterFile('lib.rs'), [], [tidy.check_rust], print_text=False)
|
||||
|
||||
self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2])
|
||||
self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2])
|
||||
self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2])
|
||||
self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2])
|
||||
self.assertNoMoreErrors(feature_errors)
|
||||
|
||||
def test_spec_link(self):
|
||||
tidy.SPEC_BASE_PATH = base_path
|
||||
errors = tidy.collect_errors_for_files(iterFile('speclink.rs'), [], [tidy.check_spec], print_text=False)
|
||||
|
||||
Reference in New Issue
Block a user