ShouldAddGlobalHistory is now a little smarter. It will only add items that are loaded in contentType'd docShells. I'm sure there are more things we should restrict on, but this is a start. r=mscott, a=jar

2000-03-01 05:18:04 +00:00
parent 1b103656f4
commit 107144891f
1 changed files with 7 additions and 3 deletions
--- a/docshell/base/nsDocShell.cpp
+++ b/docshell/base/nsDocShell.cpp
@@ -2165,10 +2165,14 @@ NS_IMETHODIMP nsDocShell::LoadHistoryEntry(nsISHEntry* aEntry)
 NS_IMETHODIMP nsDocShell::ShouldAddToGlobalHistory(nsIURI* aURI, 
   PRBool* aShouldAdd)
 {
-   *aShouldAdd = PR_TRUE;
+   if(typeContent == mItemType)
+      {
+      *aShouldAdd = PR_TRUE;
+      return NS_OK;
+      }
+
+   *aShouldAdd = PR_FALSE;

-   //XXX Should add code here for things we don't want added to global
-   // history
   return NS_OK;
 }