Bug 1960313: Stop throwing unneeded notification for stale credit card entry notifications r=dimi

Differential Revision: https://phabricator.services.mozilla.com/D250037

browser/extensions/formautofill/test/unit/test_addressRecords.js

@@ -366,11 +366,6 @@ add_task(async function test_notifyUsed() {
     getSyncChangeCounter(profileStorage.addresses, guid),
     changeCounter
   );
-
-  Assert.throws(
-    () => profileStorage.addresses.notifyUsed("INVALID_GUID"),
-    /No matching record\./
-  );
 });
 
 add_task(async function test_remove() {

browser/extensions/formautofill/test/unit/test_creditCardRecords.js

@@ -469,11 +469,6 @@ add_task(async function test_notifyUsed() {
 
   Assert.equal(creditCard.timesUsed, timesUsed + 1);
   Assert.notEqual(creditCard.timeLastUsed, timeLastUsed);
-
-  Assert.throws(
-    () => profileStorage.creditCards.notifyUsed("INVALID_GUID"),
-    /No matching record\./
-  );
 });
 
 add_task(async function test_remove() {

toolkit/components/formautofill/FormAutofillStorageBase.sys.mjs

@@ -539,7 +539,9 @@ class AutofillRecords {
 
     let recordFound = this._findByGUID(guid);
     if (!recordFound) {
-      throw new Error("No matching record.");
+      // record must have been deleted, nothing to update
+      this.log.debug("Cannot notify. No record found with guid:", guid);
+      return;
     }
 
     recordFound.timesUsed++;