From 0c35bb4f68f396d08f8e3c04af133734e7e8948e Mon Sep 17 00:00:00 2001 From: Thomas Wisniewski Date: Thu, 13 Mar 2025 20:37:14 +0000 Subject: [PATCH] Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub Differential Revision: https://phabricator.services.mozilla.com/D240671 --- .eslintrc-rollouts.js | 5 - .eslintrc-test-paths.js | 1 - .../base/content/appmenu-viewcache.inc.xhtml | 2 +- browser/base/content/browser-menubar.inc | 6 +- browser/base/content/browser-menubar.js | 3 - browser/base/content/browser.js | 16 - browser/base/content/browser.js.globals | 1 - .../static/browser_all_files_referenced.js | 9 +- .../content/protectionsPanel.inc.xhtml | 2 +- .../customizableui/content/panelUI.js | 3 - .../reportbrokensite/ReportBrokenSite.sys.mjs | 63 ++-- .../test/browser/browser.toml | 8 +- .../test/browser/browser_parent_menuitems.js | 26 +- .../browser_report_site_issue_fallback.js | 86 ----- .../browser/browser_webcompat.com_fallback.js | 69 ++++ .../reportbrokensite/test/browser/head.js | 112 +++---- .../test/browser/send_more_info.js | 35 +- browser/extensions/moz.build | 1 - .../extensions/report-site-issue/.eslintrc.js | 52 --- .../report-site-issue/background.js | 96 ------ .../experimentalAPIs/helpMenu.js | 38 --- .../experimentalAPIs/helpMenu.json | 28 -- .../experimentalAPIs/tabExtras.js | 53 --- .../experimentalAPIs/tabExtras.json | 37 --- .../locales/en-US/webcompat.properties | 10 - .../report-site-issue/locales/jar.mn | 8 - .../report-site-issue/locales/moz.build | 7 - .../report-site-issue/manifest.json | 44 --- .../extensions/report-site-issue/moz.build | 31 -- .../test/browser/browser.toml | 17 - .../test/browser/browser_button_state.js | 52 --- .../test/browser/browser_disabled_cleanup.js | 41 --- .../test/browser/browser_report_site_issue.js | 311 ------------------ .../test/browser/fastclick.html | 11 - .../test/browser/frameworks.html | 8 - .../report-site-issue/test/browser/head.js | 117 ------- .../report-site-issue/test/browser/test.html | 39 --- .../test/browser/webcompat.html | 85 ----- browser/locales/Makefile.in | 2 - browser/locales/en-US/browser/appmenu.ftl | 2 - browser/locales/en-US/browser/menubar.ftl | 2 - browser/locales/filter.py | 1 - browser/locales/l10n.ini | 1 - browser/locales/l10n.toml | 4 - mots.yaml | 7 +- .../mozbuild/test/repackaging/test_deb.py | 1 - .../test/data/bugbug-push-schedules.json | 4 - testing/runtimes/manifest-runtimes-unix.json | 1 - .../runtimes/manifest-runtimes-windows.json | 1 - tools/lint/codespell.yml | 1 - tools/lint/l10n.yml | 1 - 51 files changed, 188 insertions(+), 1373 deletions(-) delete mode 100644 browser/components/reportbrokensite/test/browser/browser_report_site_issue_fallback.js create mode 100644 browser/components/reportbrokensite/test/browser/browser_webcompat.com_fallback.js delete mode 100644 browser/extensions/report-site-issue/.eslintrc.js delete mode 100644 browser/extensions/report-site-issue/background.js delete mode 100644 browser/extensions/report-site-issue/experimentalAPIs/helpMenu.js delete mode 100644 browser/extensions/report-site-issue/experimentalAPIs/helpMenu.json delete mode 100644 browser/extensions/report-site-issue/experimentalAPIs/tabExtras.js delete mode 100644 browser/extensions/report-site-issue/experimentalAPIs/tabExtras.json delete mode 100644 browser/extensions/report-site-issue/locales/en-US/webcompat.properties delete mode 100644 browser/extensions/report-site-issue/locales/jar.mn delete mode 100644 browser/extensions/report-site-issue/locales/moz.build delete mode 100644 browser/extensions/report-site-issue/manifest.json delete mode 100644 browser/extensions/report-site-issue/moz.build delete mode 100644 browser/extensions/report-site-issue/test/browser/browser.toml delete mode 100644 browser/extensions/report-site-issue/test/browser/browser_button_state.js delete mode 100644 browser/extensions/report-site-issue/test/browser/browser_disabled_cleanup.js delete mode 100644 browser/extensions/report-site-issue/test/browser/browser_report_site_issue.js delete mode 100644 browser/extensions/report-site-issue/test/browser/fastclick.html delete mode 100644 browser/extensions/report-site-issue/test/browser/frameworks.html delete mode 100644 browser/extensions/report-site-issue/test/browser/head.js delete mode 100644 browser/extensions/report-site-issue/test/browser/test.html delete mode 100644 browser/extensions/report-site-issue/test/browser/webcompat.html diff --git a/.eslintrc-rollouts.js b/.eslintrc-rollouts.js index 2f5e9e20a87a..d3bbae68d687 100644 --- a/.eslintrc-rollouts.js +++ b/.eslintrc-rollouts.js @@ -455,7 +455,6 @@ const rollouts = [ "browser/extensions/formautofill/**", "browser/extensions/newtab/**", "browser/extensions/pictureinpicture/**", - "browser/extensions/report-site-issue/test/browser/head.js", "browser/extensions/search-detection/extension/background.js", "browser/extensions/webcompat/**", "browser/fxr/content/permissions.js", @@ -1077,10 +1076,6 @@ const rollouts = [ "browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_indexes.js", "browser/extensions/formautofill/test/browser/browser_dropdown_layout.js", "browser/extensions/formautofill/test/browser/creditCard/browser_anti_clickjacking.js", - "browser/extensions/report-site-issue/test/browser/browser_button_state.js", - "browser/extensions/report-site-issue/test/browser/browser_disabled_cleanup.js", - "browser/extensions/report-site-issue/test/browser/browser_report_site_issue.js", - "browser/extensions/report-site-issue/test/browser/head.js", "browser/extensions/webcompat/tests/browser/head.js", "browser/modules/test/browser/browser_PageActions.js", "browser/modules/test/browser/browser_PageActions_contextMenus.js", diff --git a/.eslintrc-test-paths.js b/.eslintrc-test-paths.js index 9cc1d9684d4e..db88223f8807 100644 --- a/.eslintrc-test-paths.js +++ b/.eslintrc-test-paths.js @@ -131,7 +131,6 @@ const extraBrowserTestPaths = [ "browser/components/shell/test/", "browser/components/touchbar/tests/", "browser/components/uitour/test/", - "browser/extensions/report-site-issue/test/browser/", "browser/tools/mozscreenshots/", "caps/tests/mochitest/", "devtools/client/debugger/test/mochitest/", diff --git a/browser/base/content/appmenu-viewcache.inc.xhtml b/browser/base/content/appmenu-viewcache.inc.xhtml index cb086fecbbc1..ccbcc536ddeb 100644 --- a/browser/base/content/appmenu-viewcache.inc.xhtml +++ b/browser/base/content/appmenu-viewcache.inc.xhtml @@ -142,7 +142,7 @@ class="subviewbutton subviewbutton-nav" data-l10n-id="appmenuitem-report-broken-site" closemenu="none" - hidden="true" + disabled="true" command="cmd_reportBrokenSite"/>