corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1491925. Remove the various instrumentation we added to pin down InnerSetNewDocument failures. r=mccr8.

Browse Source 
This is a straight backout of (in that order) bug 1505468, bug 1503664, bug
1501479, bug 1499150, bug 1496805, and the second part of bug 1493849.  The
first part of bug 1493849 was a backout of earlier instrumentation, and that
should stay.

At this point we know we're hitting OOM inside the JS engine while trying to
define properties on Document.prototype, so all this MOZ_CRASH instrumentation
is no longer needed.
This commit is contained in:
Boris Zbarsky
2018-11-28 18:24:53 -05:00
parent 80e8f59f1a
commit 0aefc94e45
8 changed files with 22 additions and 218 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dom/html/nsHTMLDocument.cpp
View File

@@ -203,11 +203,7 @@ NS_IMPL_ISUPPORTS_CYCLE_COLLECTION_INHERITED(nsHTMLDocument,
JSObject*
nsHTMLDocument::WrapNode(JSContext* aCx, JS::Handle<JSObject*> aGivenProto)
{
JSObject* obj = HTMLDocument_Binding::Wrap(aCx, this, aGivenProto);
if (!obj) {
MOZ_CRASH("Looks like bug 1488480/1405521, with nsHTMLDocument::WrapNode failing");
}
return obj;
return HTMLDocument_Binding::Wrap(aCx, this, aGivenProto);
}
nsresult