corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Backed out 5 changesets (bug 1468754) for xpcshell and eslint failures. CLOSED TREE

Browse Source 
Backed out changeset 67f969f5bdba (bug 1468754)
Backed out changeset 55ba74fa5c95 (bug 1468754)
Backed out changeset 0d44a0523525 (bug 1468754)
Backed out changeset da447a45603e (bug 1468754)
Backed out changeset 71f45c79522e (bug 1468754)
This commit is contained in:
Dorel Luca
2018-10-22 22:00:49 +03:00
parent 6aaede76ec
commit 07b5accb27
13 changed files with 4 additions and 232 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
devtools/client/inspector/changes/ChangesView.js
View File

@@ -13,24 +13,15 @@ const ChangesApp = createFactory(require("./components/ChangesApp"));
const {
resetChanges,
trackChange,
} = require("./actions/changes");
class ChangesView {
constructor(inspector) {
this.inspector = inspector;
this.store = this.inspector.store;
this.toolbox = this.inspector.toolbox;
this.onAddChange = this.onAddChange.bind(this);
this.onClearChanges = this.onClearChanges.bind(this);
this.destroy = this.destroy.bind(this);
// Get the Changes front, and listen to it.
this.changesFront = this.toolbox.target.getFront("changes");
this.changesFront.on("add-change", this.onAddChange);
this.changesFront.on("clear-changes", this.onClearChanges);
this.init();
}
@@ -47,33 +38,6 @@ class ChangesView {
// TODO: save store and restore/replay on refresh.
// Bug 1478439 - https://bugzilla.mozilla.org/show_bug.cgi?id=1478439
this.inspector.target.once("will-navigate", this.destroy);
// Sync the store to the changes stored on the server. The
// syncChangesToServer() method is async, but we don't await it since
// this method itself is NOT async. The call will be made in its own
// time, which is fine since it definitionally brings us up-to-date
// with the server at that moment.
this.syncChangesToServer();
}
async syncChangesToServer() {
// Empty the store.
this.onClearChanges();
// Add back in all the changes from the changesFront.
const changes = await this.changesFront.allChanges();
changes.forEach((change) => {
this.onAddChange(change);
});
}
onAddChange(change) {
// Turn data into a suitable change to send to the store.
this.store.dispatch(trackChange(change));
}
onClearChanges() {
this.store.dispatch(resetChanges());
}
/**
@@ -81,14 +45,8 @@ class ChangesView {
*/
destroy() {
this.store.dispatch(resetChanges());
this.changesFront.off("add-change", this.onAddChange);
this.changesFront.off("clear-changes", this.onClearChanges);
this.changesFront = null;
this.inspector = null;
this.store = null;
this.toolbox = null;
}
}