From 05eb5b8275581e429be26e75bf05c47ddb4056d2 Mon Sep 17 00:00:00 2001 From: Julien Cristau Date: Tue, 20 May 2025 08:20:23 +0000 Subject: [PATCH] Bug 1930713 - ignore leak from mesa's libgallium. r=gfx-reviewers,decoder,lsalzman ``` ==1410==ERROR: LeakSanitizer: detected memory leaks Direct leak of 2352 byte(s) in 49 object(s) allocated from: #0 0x562318d9d2df in malloc /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:68:3 #1 0x7f169f73a499 in ralloc_size /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/ralloc.c:118:18 #2 0x7f169f73a499 in ralloc_context /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/ralloc.c:105:11 #3 0x7f169f75f399 in mesa_cache_db_open /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/mesa_cache_db.c:675:18 #4 0x7f169f741c99 in mesa_cache_db_multipart_init_part_locked /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/mesa_cache_db_multipart.c:60:16 #5 0x7f169f741c99 in mesa_cache_db_multipart_init_part /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/mesa_cache_db_multipart.c:93:10 #6 0x7f169f741f16 in mesa_cache_db_multipart_init_part /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/mesa_cache_db_multipart.c:89:7 #7 0x7f169f741f16 in mesa_cache_db_multipart_read_entry /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/mesa_cache_db_multipart.c:136:12 #8 0x7f169f733f9d in disk_cache_db_load_item /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/disk_cache_os.c:1167:23 #9 0x7f169f73238d in disk_cache_get /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/util/disk_cache.c:605:16 #10 0x7f169fafc569 in shader_cache_read_program_metadata(gl_context*, gl_shader_program*) /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/compiler/glsl/shader_cache.cpp:214:48 #11 0x7f169fae839b in link_shaders(gl_context*, gl_shader_program*) /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/compiler/glsl/linker.cpp:1766:42 #12 0x7f169fa509aa in st_link_shader /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/mesa/state_tracker/st_glsl_to_nir.cpp:984:22 #13 0x7f169fa05e8e in link_program /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/mesa/main/shaderapi.c:1337:4 #14 0x7f169fa05e8e in link_program_error /usr/src/mesa-24.2.8-1ubuntu1~24.04.1/build/../src/mesa/main/shaderapi.c:1446:4 #15 0x7f16e74f1ae6 in webrender::device::gl::Device::link_program::h04ace192966fed71 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/device/gl.rs:2518:13 #16 0x7f16e74fc25f in webrender::device::gl::Device::create_program_linked::h2ec223b25e78d716 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/device/gl.rs:3035:9 #17 0x7f16e75161b3 in webrender::renderer::gpu_cache::GpuCacheTexture::new::hf7ba56012a504794 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/renderer/gpu_cache.rs:165:27 #18 0x7f16e7528446 in webrender::renderer::init::create_webrender_instance::h559ddbaf7f9a386b /builds/worker/checkouts/gecko/gfx/wr/webrender/src/renderer/init.rs:517:29 #19 0x7f16e76e8d8f in wr_window_new /builds/worker/checkouts/gecko/gfx/webrender_bindings/src/bindings.rs:2068:36 #20 0x7f16d8d6d980 in mozilla::wr::NewRenderer::Run(mozilla::wr::RenderThread&, mozilla::wr::WrWindowId) /builds/worker/checkouts/gecko/gfx/webrender_bindings/WebRenderAPI.cpp:134:10 #21 0x7f16d8d2fbfa in mozilla::wr::RenderThread::RunEvent(mozilla::wr::WrWindowId, mozilla::UniquePtr>, bool) /builds/worker/checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:755:11 #22 0x7f16d8d4b478 in operator() &, StoreCopyPassByRRef > > &, StoreCopyPassByConstLRef &> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1085:18 #23 0x7f16d8d4b478 in __invoke_impl &, StoreCopyPassByRRef > > &, StoreCopyPassByConstLRef &> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:60:14 #24 0x7f16d8d4b478 in __invoke<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9), StoreCopyPassByConstLRef &, StoreCopyPassByRRef > > &, StoreCopyPassByConstLRef &> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:95:14 #25 0x7f16d8d4b478 in __apply_impl<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9), std::tuple, StoreCopyPassByRRef > >, StoreCopyPassByConstLRef > &, 0UL, 1UL, 2UL> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1678:14 #26 0x7f16d8d4b478 in apply<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9), std::tuple, StoreCopyPassByRRef > >, StoreCopyPassByConstLRef > &> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1687:14 #27 0x7f16d8d4b478 in apply >, bool)> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1083:12 #28 0x7f16d8d4b478 in mozilla::detail::RunnableMethodImpl>, bool), true, (mozilla::RunnableKind)0, mozilla::wr::WrWindowId, mozilla::UniquePtr>&&, bool>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1134:13 #29 0x7f16d607b26c in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1153:16 #30 0x7f16d6085848 in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:480:10 #31 0x7f16d74ee3fa in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:329:5 #32 0x7f16d73fc7c4 in RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:369:10 #33 0x7f16d73fc7c4 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:362:3 #34 0x7f16d73fc7c4 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:344:3 #35 0x7f16d60740ae in nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:366:10 #36 0x7f16f0deb74b in _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:191:3 #37 0x562318d99546 in asan_thread_start(void*) /builds/worker/fetches/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:239:28 ``` Differential Revision: https://phabricator.services.mozilla.com/D250035 --- build/sanitizers/AsanOptions.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/build/sanitizers/AsanOptions.cpp b/build/sanitizers/AsanOptions.cpp index 0eebbe7ca7bd..c7cd89b0e56c 100644 --- a/build/sanitizers/AsanOptions.cpp +++ b/build/sanitizers/AsanOptions.cpp @@ -149,6 +149,10 @@ extern "C" MOZ_EXPORT const char* __lsan_default_suppressions() { // RegisteredThread::RegisteredThread, mozilla::detail::UniqueSelector "leak:RegisteredThread::RegisteredThread\n" + // Bug 1967251 - leak at ralloc_size, ralloc_context, + // mesa_cache_db_open, mesa_cache_db_multipart_init_part_locked + "leak:mesa_cache_db_open\n" + // // Leaks with system libraries in their stacks. These show up across a // number of tests. Better symbols and disabling fast stackwalking may