corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1376126 - Use Lookup() entry instead of Get+Remove in CycleCollectedJSRuntime::RemoveJSHolder to avoid unnecessary hashtable lookups. r=froydnj

Browse Source 
MozReview-Commit-ID: F2dJbf9r44b
This commit is contained in:
Mats Palmgren
2017-06-28 01:03:17 +02:00
parent 1e0a1559f5
commit 05d086cda1
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
xpcom/base/CycleCollectedJSRuntime.cpp
View File

@@ -1101,12 +1101,10 @@ struct ClearJSHolder : public TraceCallbacks
void
CycleCollectedJSRuntime::RemoveJSHolder(void* aHolder)
{
nsScriptObjectTracer* tracer = mJSHolders.Get(aHolder);
if (!tracer) {
return;
if (auto entry = mJSHolders.Lookup(aHolder)) {
entry.Data()->Trace(aHolder, ClearJSHolder(), nullptr);
entry.Remove();
}
tracer->Trace(aHolder, ClearJSHolder(), nullptr);
mJSHolders.Remove(aHolder);
}
#ifdef DEBUG