corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1295440 - Make HTMLMediaElement::SeekToNextFrame() reject promise with meaningful information; r=jwwang

Browse Source 
MozReview-Commit-ID: Dgi3Ek8K3bR
This commit is contained in:
Kaku Kuo
2016-08-17 10:02:10 +08:00
parent 8bffcf75e9
commit 04c743da91
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/html/HTMLMediaElement.cpp
View File

@@ -1722,7 +1722,7 @@ HTMLMediaElement::Seek(double aTime,
if (mSrcStream) {
// do nothing since media streams have an empty Seekable range.
promise->MaybeRejectWithUndefined();
promise->MaybeReject(NS_ERROR_DOM_INVALID_STATE_ERR);
return promise.forget();
}
@@ -1740,14 +1740,14 @@ HTMLMediaElement::Seek(double aTime,
if (mReadyState == nsIDOMHTMLMediaElement::HAVE_NOTHING) {
mDefaultPlaybackStartPosition = aTime;
promise->MaybeRejectWithUndefined();
promise->MaybeReject(NS_ERROR_DOM_INVALID_STATE_ERR);
return promise.forget();
}
if (!mDecoder) {
// mDecoder must always be set in order to reach this point.
NS_ASSERTION(mDecoder, "SetCurrentTime failed: no decoder");
promise->MaybeRejectWithUndefined();
promise->MaybeReject(NS_ERROR_DOM_INVALID_STATE_ERR);
return promise.forget();
}
@@ -1762,7 +1762,7 @@ HTMLMediaElement::Seek(double aTime,
uint32_t length = 0;
seekable->GetLength(&length);
if (!length) {
promise->MaybeRejectWithUndefined();
promise->MaybeReject(NS_ERROR_DOM_INVALID_STATE_ERR);
return promise.forget();
}