corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Backed out changeset a224934d4790 (bug 1786523) for causing multiple failures in browser_siteData_multi_select/browser_aboutwelcome_multistage_mr CLOSED TREE

Browse Source
This commit is contained in:
Sandor Molnar
2022-09-13 22:27:08 +03:00
parent 34ca3f76fa
commit 03d1865f8f
4 changed files with 2 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
toolkit/components/messaging-system/lib/SpecialMessageActions.jsm
View File

@@ -310,18 +310,7 @@ const SpecialMessageActions = {
(data && data.entrypoint) || "snippets",
(data && data.extraParams) || {}
);
// if a location is specified, use that
if (data.where) {
window.openLinkIn(url, data.where, {
private: false,
triggeringPrincipal: Services.scriptSecurityManager.createNullPrincipal(
{}
),
csp: null,
});
break;
}
// If no location was specified, we want to replace the current tab.
// We want to replace the current tab.
window.openLinkIn(url, "current", {
private: false,
triggeringPrincipal: Services.scriptSecurityManager.createNullPrincipal(

20
toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser_sma_show_firefox_accounts.js
View File

@@ -43,24 +43,4 @@ add_task(async function test_SHOW_FIREFOX_ACCOUNTS() {
"should load fxa with a custom endpoint and extra parameters in url"
);
});
add_task(async function test_SHOW_FIREFOX_ACCOUNTS_where() {
// Open FXA with a 'where' prop
const action = {
type: "SHOW_FIREFOX_ACCOUNTS",
data: {
entrypoint: "activity-stream-firstrun",
where: "tab",
},
};
const tabPromise = BrowserTestUtils.waitForNewTab(
gBrowser,
"https://example.com/?context=fx_desktop_v3&entrypoint=activity-stream-firstrun&action=email&service=sync"
);
await SpecialMessageActions.handleAction(action, gBrowser);
const browser = await tabPromise;
ok(browser, "should open FXA in a new tab");
BrowserTestUtils.removeTab(browser);
});
});