corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1302379 - Remove FinishedOnInactive hack from DOMMediaStream. r=jib

Browse Source 
It is no longer needed with captured tracks' lifetimes spanning across seek
operations.

Differential Revision: https://phabricator.services.mozilla.com/D52051
This commit is contained in:
Andreas Pehrson
2019-11-13 08:58:32 +00:00
parent 1910f3d4f3
commit 0341a6732b
3 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dom/html/HTMLMediaElement.cpp
View File

@@ -1709,9 +1709,6 @@ NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(HTMLMediaElement,
}
NS_IMPL_CYCLE_COLLECTION_UNLINK(mAudioChannelWrapper)
NS_IMPL_CYCLE_COLLECTION_UNLINK(mErrorSink->mError)
for (OutputMediaStream& s : tmp->mOutputStreams) {
s.mStream->SetFinishedOnInactive(true);
}
NS_IMPL_CYCLE_COLLECTION_UNLINK(mOutputStreams)
NS_IMPL_CYCLE_COLLECTION_UNLINK(mOutputTrackSources)
NS_IMPL_CYCLE_COLLECTION_UNLINK(mPlayed)
@@ -3320,7 +3317,6 @@ void HTMLMediaElement::UpdateOutputTrackSources() {
LOG(LogLevel::Debug,
("Playback ended or source changed. Discarding stream %p",
mOutputStreams[i].mStream.get()));
mOutputStreams[i].mStream->SetFinishedOnInactive(true);
mOutputStreams.RemoveElementAt(i);
if (mOutputStreams.IsEmpty()) {
mTracksCaptured = nullptr;