corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1444143 part 2. Remove nsIFrameLoader::GetDocShell. r=mystor

Browse Source 
The change from "docShell" to "mDocShell" for the SetName call in the
OwnerIsMozBrowserFrame case in nsFrameLoader::MaybeCreateDocShell is a
drive-by correctness fix for a bug the rename of "docShell" to "parentDocShell"
caught: setting the name of our _parent_ docshell based on the name attr of our
owner makes no sense.

MozReview-Commit-ID: DwnWt8jTokV
This commit is contained in:
Boris Zbarsky
2018-03-21 22:43:15 -04:00
parent 8bb985656b
commit 0151a30a4d
12 changed files with 45 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
dom/html/nsGenericHTMLFrameElement.cpp
View File

@@ -127,8 +127,7 @@ nsGenericHTMLFrameElement::GetContentWindow()
return nullptr;
}
nsCOMPtr<nsIDocShell> doc_shell;
mFrameLoader->GetDocShell(getter_AddRefs(doc_shell));
nsCOMPtr<nsIDocShell> doc_shell = mFrameLoader->GetDocShell(IgnoreErrors());
if (!doc_shell) {
return nullptr;
}