corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1938075 - Remove inline event handler from buildOtherBookmarksFolder. r=places-reviewers,mak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D232492
This commit is contained in:
Tom Schuster
2024-12-19 16:47:29 +00:00
parent 3f1e1a9678
commit 014e7c25af
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
browser/base/content/browser-places.js
View File

@@ -2237,13 +2237,14 @@ var BookmarkingUI = {
let otherBookmarksButton = document.createXULElement("toolbarbutton"); let otherBookmarksButton = document.createXULElement("toolbarbutton");
otherBookmarksButton.setAttribute("type", "menu"); otherBookmarksButton.setAttribute("type", "menu");
otherBookmarksButton.setAttribute("container", "true"); otherBookmarksButton.setAttribute("container", "true");
otherBookmarksButton.setAttribute(
"onpopupshowing",
"document.getElementById('PlacesToolbar')._placesView._onOtherBookmarksPopupShowing(event);"
);
otherBookmarksButton.id = "OtherBookmarks"; otherBookmarksButton.id = "OtherBookmarks";
otherBookmarksButton.className = "bookmark-item"; otherBookmarksButton.className = "bookmark-item";
otherBookmarksButton.hidden = "true"; otherBookmarksButton.hidden = "true";
otherBookmarksButton.addEventListener("popupshowing", event =>
document
.getElementById("PlacesToolbar")
._placesView._onOtherBookmarksPopupShowing(event)
);
MozXULElement.insertFTLIfNeeded("browser/places.ftl"); MozXULElement.insertFTLIfNeeded("browser/places.ftl");
document.l10n.setAttributes(otherBookmarksButton, "other-bookmarks-folder"); document.l10n.setAttributes(otherBookmarksButton, "other-bookmarks-folder");